use getsockopt to check connection state after poll indicate writable #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOON-CLJ
changed the title
MOON-CLJ
changed the title
|
Could you add more details on why we need this? It'd would best if you could add a test case or a piece of POC code to reproduce the issue you want to fix. |
|
@mckelvin this pr contains two points， 1，as suggestion by https://man.openbsd.org/connect.2 ，also see the https://man.openbsd.org/connect.2#EXAMPLES 。 add getsockopt with option SO_ERROR after poll indicate ok to double check after connect。it's not easy to add a test。 |
tclh123
reviewed
Jan 31, 2019
| @@ -134,23 +135,44 @@ int Connection::connectPoll(int fd, struct addrinfo* ai_ptr) { | |||
| pollfd_t pollfds[n_fds]; | |||
| pollfds[0].fd = fd; | |||
| pollfds[0].events = POLLOUT; | |||
| // clean errno | |||
| errno = 0; | |||
There was a problem hiding this comment.
@tclh123 https://github.com/douban/libmc/blob/master/include/Common.h#L61 log will use errno，if not clean here。such as EINPROGRESS EALREADY above will show in the log，it's noisy。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.