Skip to content

Commit

Permalink
Re-enable missing cmdTests
Browse files Browse the repository at this point in the history
It might have been disabled by mistake because bootstrapCmdTests was
assumed to be the set of tests for the bootstrapped compiler.
The second is an extension for the second with tests that can only
be run on the bootstrapped compiler. It is now renamed to
bootstrappedOnlyCmdTests to make sure we avoid this potential confusion.

Fixes scala#14416
  • Loading branch information
nicolasstucki committed Feb 7, 2022
1 parent 733af41 commit f9a2a0a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ jobs:
- name: Cmd Tests
run: |
./project/scripts/sbt ";dist/pack; scala3-bootstrapped/compile; scala3-bootstrapped/test;sjsSandbox/run;sjsSandbox/test;sjsJUnitTests/test;sjsCompilerTests/test ;sbt-test/scripted scala2-compat/* ;configureIDE ;stdlib-bootstrapped/test:run ;stdlib-bootstrapped-tasty-tests/test; scala3-compiler-bootstrapped/scala3CompilerCoursierTest:test"
./project/scripts/bootstrapCmdTests
./project/scripts/cmdTests
./project/scripts/bootstrappedOnlyCmdTests
- name: MiMa
run: |
Expand Down Expand Up @@ -447,7 +448,8 @@ jobs:
- name: Test
run: |
./project/scripts/sbt ";dist/pack ;scala3-bootstrapped/compile ;scala3-bootstrapped/test;sjsSandbox/run;sjsSandbox/test;sjsJUnitTests/test;sjsCompilerTests/test ;sbt-test/scripted scala2-compat/* ;configureIDE ;stdlib-bootstrapped/test:run ;stdlib-bootstrapped-tasty-tests/test"
./project/scripts/bootstrapCmdTests
./project/scripts/cmdTests
./project/scripts/bootstrappedOnlyCmdTests
publish_nightly:
runs-on: [self-hosted, Linux]
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/pos/i12973.scala
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Compiled and placed on the REPL classpath in the bootstrapCmdTests script
// Compiled and placed on the REPL classpath in the bootstrappedOnlyCmdTests script
// to test that launching the REPL with `scala -cp <path>` works (issue #12973)
case class Bug12973():
def check = s"$productPrefix is fixed"

0 comments on commit f9a2a0a

Please sign in to comment.