Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly realtime live location #33

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

enriquemdev
Copy link
Contributor

Description

This PR addresses issue #26 by making the map's live location functionality more flexible, unrestricted and configurable.

Changes:

  • Removed Restriction on Current Location: Removed the condition that restricted obtaining the current location only when the map's draggable option was set to true.
  • Enhanced liveLocation Option: Modified the liveLocation option to make it configurable, allowing the map to obtain the user's real-time location at specified intervals.

These changes make the map's live location tracking more versatile and applicable in a wider range of scenarios, even when the map is not draggable.

Impact:

  • Improved UX: Users can now get real-time location updates without needing the map to be draggable.
  • Customization: Developers can specify the interval for obtaining real-time location updates, providing more control over the feature.

@mohaphez
Copy link
Member

Thank you, @enriquemdev, for the great work!

Please remove the comments and delete the .phpunit.cache/test-results folder. Once that's done, we'll be ready to merge.

Could you also add this folder to the .gitignore? Additionally, could you update the README file to include the new options in the documentation?

Thanks in advance .

@mohaphez mohaphez linked an issue Sep 12, 2024 that may be closed by this pull request
@enriquemdev
Copy link
Contributor Author

Thank you, @mohaphez!

I’ve removed the comments, deleted the .phpunit.cache/test-results folder, and added it to the .gitignore. I've also updated the README with the new options.

Let me know if anything else is needed!

@mohaphez mohaphez merged commit 5d1ed9f into dotswan:master Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map dont set value on draggrable on false
2 participants