[release/1.1] Add CodeQL3000 to microsoft-reverse-proxy-official #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- backport of dotnet#1914 - add a new weekly schedule to keep database and tools up to database - add top-level parameter enabling CodeQL3000 in manual builds - add CodeQL3000 variables - add CodeQL3000 tasks - not auto-injected because that happens only in builds of the default branch - add tag indicating CodeQL3000 tasks did useful work - ignore no-op task executions - add a tsaoptions.json file - cribbed values from eng/sdl-tsa-vars.config file also: - backport dotnet#1843 - backport dotnet#1848 - switch to `-Svc` pools since this is a servicing branch nits: - disable auto-injection of build steps we or Arcade do explicitly - remove irrelevant variables in test jobs
dougbu
commented
Nov 2, 2022
Comment on lines
+49
to
53
| name: NetCore-Svc-Public | ||
| demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open | ||
| ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| name: NetCore1ESPool-Internal | ||
| name: NetCore1ESPool-Svc-Internal | ||
| demands: ImageOverride -equals Build.Ubuntu.1804.Amd64 |
There was a problem hiding this comment.
@jonfortescue @alexperovich @MattGal are these the correct pool and image names these days (for a servicing branch)❔
MattGal
approved these changes
Nov 2, 2022
Comment on lines
+49
to
53
| name: NetCore-Svc-Public | ||
| demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open | ||
| ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| name: NetCore1ESPool-Internal | ||
| name: NetCore1ESPool-Svc-Internal | ||
| demands: ImageOverride -equals Build.Ubuntu.1804.Amd64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also:
-Svcpools since this is a servicing branchnits: