[iOS] Add basic classes to support the usage of tunnels. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the basic classes that are needed to support the creation of tcp tunnels to the devices. A following commit will provide the required CLI option and integration to the runner to support this.
|
Please review in case something need to be changed in the API, once is approved and merged I'll add support for it, atm is not used. |
premun
reviewed
Apr 23, 2020
...Harness.iOS.Shared/TestImporter/Templates/Managed/Resources/src/common/ApplicationOptions.cs
Show resolved
Hide resolved
premun
requested changes
Apr 23, 2020
| { | ||
| var se = e as SocketException; | ||
| if (se == null || se.SocketErrorCode != SocketError.Interrupted) | ||
| Console.WriteLine("[{0}] : {1}", DateTime.Now, e); |
There was a problem hiding this comment.
@mandel-macaque is this still open?
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/SimpleTcpListener.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TcpTunnel.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TunnelBore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TunnelBore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TunnelBore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TunnelBore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.iOS.Shared/Listeners/TunnelBore.cs
Outdated
Show resolved
Hide resolved
....Shared/TestImporter/Templates/Managed/Resources/src/common/TestRunner/Core/TcpTextWriter.cs
Show resolved
Hide resolved
…stener.cs As per review comments. Co-Authored-By: Přemek Vysoký <[email protected]>
… to clean resources better.
|
Failing tests are unrelated, but merging with master should fix them. |
premun
approved these changes
Apr 23, 2020
MattGal
approved these changes
Apr 23, 2020
|
|
||
| public TcpTunnelArgument(int port) | ||
| { | ||
| if (port <= 0) |
There was a problem hiding this comment.
impossible for this to be null or > 65535?
There was a problem hiding this comment.
int cannot be null, if is too large, the exception will be raised later
| } | ||
| catch (SocketException ex) | ||
| { | ||
| if (timeout == 100 && watch.ElapsedMilliseconds > 20000) |
There was a problem hiding this comment.
Seems like the kind of values that might be nice to be constants at the top of the file
| namespace Microsoft.DotNet.XHarness.iOS.Shared.Listeners | ||
| { | ||
|
|
||
| // interface to be implemented by those listener that can use a tcp tunnel |
| public Task<bool> Started { get; } | ||
| } | ||
|
|
||
| // represents a tunnel created between a device and a host. This tunnel allows the communication between |
| new DeviceNameArgument (device), | ||
| }; | ||
|
|
||
| // use a cancelation token, later will be used to kill the tcp tunnel proces |
| simpleListener.TunnelHoleThrough.TrySetResult(true); | ||
| } | ||
| }); | ||
| // do not await since we are going to be running the process is parallel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the basic classes that are needed to support the creation of tcp
tunnels to the devices. A following commit will provide the required CLI
option and integration to the runner to support this.