Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CORS response expose headers #624

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Allow CORS response expose headers #624

merged 1 commit into from
Jun 3, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jun 3, 2021 •
edited
Loading

Allow response headers to be visible in wasm/JS.
To fix wasm tests dotnet/runtime#53668

@pavelsavara pavelsavara mentioned this pull request Jun 3, 2021
Closed
@pavelsavara pavelsavara changed the title Allow CORS response headers Allow CORS response expose headers Jun 3, 2021
@pavelsavara pavelsavara requested a review from mdh1418 June 3, 2021 15:24
mdh1418
mdh1418 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pavelsavara pavelsavara enabled auto-merge (squash) June 3, 2021 15:34
@pavelsavara
Copy link
Member Author

pavelsavara commented Jun 3, 2021 •
edited
Loading

fail: Microsoft.DotNet.XHarness.Common.CLI.NoDeviceFoundException: Could not find any applicable devices with device class(es): iPhone, iPad, iPod
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-xharness-refs-pull-624-merge-c39cebff478e401384/System.Buffers.Tests/console.52b3b14c.log?sv=2019-07-07&se=2021-06-23T14%3A58%3A20Z&sr=c&sp=rl&sig=OC9yHbRlEsAIS3GwuGkXpSRJT7uQ00M81GxQWo%2Fj4EI%3D

@pavelsavara pavelsavara merged commit c93bf0e into dotnet:main Jun 3, 2021
@premun premun mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdh1418 mdh1418 mdh1418 approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @mdh1418