Stop accepting multiple test targets #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Apple/AppleTestCommandArguments.cs
Show resolved
Hide resolved
greenEkatherine
approved these changes
Jun 1, 2021
premun
added a commit
to dotnet/arcade
that referenced
this pull request
Jun 3, 2021
We never supported this really and it was deprecated in dotnet/xharness#618 This will be a breaking change in the SDK: ```xml <Targets>ios-simulator-64</Targets> ``` will change to ```xml <TestTarget>ios-simulator-64</TestTarget> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remnant from the original XHarness and we cannot really run more targets at the moment. Android commands don't support this neither so it doesn't make sense as it is