Don't include d3dcompiler_47.dll on ARM64. #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested review from
|
Hi @singhashish-wpf. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
dipeshmsft
approved these changes
May 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5462
Main PR #5747
Description
Don't include d3dcompiler_47.dll on ARM64.
The included ARM64 version of d3dcompiler_47 isn’t real – it’s a stub that looks and smells real, but as soon as you try to use it, the app explodes. So, removing it for arm64.
Customer Impact
Without this change the d3dcompiler.dll which is shipped for arm64 is causing issues with 3rd party libraries.
In some cases when starting the application, the chromium browser hangs, and the log file contains an error that it cannot find the D3DCompile entry point
Regression
No
Testing
Build and CI
Risk
None.