Fix incremental build for WPF projects with dotnet.exe #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
|
|
@MichaeIDietrich: We will discuss this in the WPF triage meeting later today. Thanks. |
fabiant3
requested changes
Jan 22, 2021
src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/MS/Internal/Tasks/CompilerState.cs
Outdated
Show resolved
Hide resolved
MichaeIDietrich
force-pushed
the
fix/incremental_build
branch
from
5264f28 to
d10b3c0
Compare
|
Can this PR be completed or is there something that is missing? |
|
Apologies, @MichaeIDietrich. I didn't see that this PR had been updated. |
ryalanms
approved these changes
Jan 27, 2021
|
@fabiant3: This looks good. Can you take a look and approve? (This will go in to 6.0 Preview 2 now, and we can start the process to get it in to servicing releases for other versions.) |
|
No problem. 😄 |
fabiant3
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Thanks you for the fix @MichaeIDietrich, this should be merged shortly.
|
Thanks again, @MichaeIDietrich. |
ryalanms
pushed a commit
that referenced
this pull request
Jan 28, 2021
Co-authored-by: Michael Dietrich <[email protected]>
ryalanms
pushed a commit
that referenced
this pull request
Jan 28, 2021
Co-authored-by: Michael Dietrich <[email protected]>
ryalanms
added a commit
that referenced
this pull request
Jan 28, 2021
…4053) (#4098) Co-authored-by: Michael Dietrich <[email protected]> Co-authored-by: Michael Dietrich <[email protected]>
ryalanms
added a commit
that referenced
this pull request
Jan 28, 2021
…ler (#4099) * Add stable hashing algorithm for strings (#4053) Co-authored-by: Michael Dietrich <[email protected]> * Allow unsafe code in PresentationBuildTasks Co-authored-by: Michael Dietrich <[email protected]> Co-authored-by: Michael Dietrich <[email protected]>
|
This was approved to go in to 3.1 and 5.0 servicing releases. Thanks. |
This was referenced Jan 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incremental builds for WPF projects if
dotnet.exeis used for building.The
GetHashCode()method of strings can produce different hash values between subsequent program runs in .NET Core and cannot be used to persist theMarkupCompile.cachefile.A copy of the
GetNonRandomizedHashCode()method fromString.Comparison.csis used instead.The bug was found as part of #3876.