Remove unsupported TFM's from SupportedTargetFramework.

[vatsan-madhavan]

• Addresses Remove .NETCore <3.0 as SupportedTargetFrameworks for WinForms and WPF #1567
• Completes work started in Remove .NETCore <3.0 as SupportedTargetFrameworks for WinForms and WPF sdk#3438
• Removes unsupported TFM's from SupportedTargetFramework.

[vatsan-madhavan]

I decided to start this PR before the definition for SupportedNETStandardTargetFramework etc. flows into dotnet/wpf - I figured the change would simply be benign if those are not defined.

@peterhuene I can give you a privately build WindowsDesktop SDK based on this change - would you able to help test this with VS?

[peterhuene]

I've tested it in VS with my original suggestion (without the condition you added to the group) with a manually modified WindowsDesktop SDK. I can retest with this PR's contents too.

[vatsan-madhavan]

I've tested it in VS with my original suggestion (without the condition you added to the group) with a manually modified WindowsDesktop SDK. I can retest with this PR's contents too.

That's really the interesting portion. Take a WPF or Windows Forms app, remove UseWPF or UseWindowsForms and see if it behaves ok, set TFM to netcoreapp2.0 and see if it behaves ok etc.

Microsoft.NET.Sdk.WindowsDesktop.3.0.0-dev.zip

[peterhuene]

I'll test that out.

[peterhuene]

Without UseWpf/UseWindowsForms, I get NETSDK1106: Microsoft.NET.Sdk.WindowsDesktop requires 'UseWpf' or 'UseWindowsForms' to be set to 'true'. I get the full list of .NET Core App target frameworks. With either property set, I get just 3.0 (I have to reload the project, though; the project properties doesn't seem to re-evaluate the supported frameworks upon project changes).

[vatsan-madhavan]

Without UseWpf/UseWindowsForms, I get NETSDK1106: Microsoft.NET.Sdk.WindowsDesktop requires 'UseWpf' or 'UseWindowsForms' to be set to 'true'. I get the full list of .NET Core App target frameworks.

That's what I would expect. The warning is suppressible and we designed it that way to enable certain scenarios.

With either property set, I get just 3.0 (I have to reload the project, though; the project properties doesn't seem to re-evaluate the supported frameworks upon project changes).

great!

Would you mind testing to see what happens when you set TFM to netcoreapp2.2. in your project by hand? This is clearly not natural scenario, but I think it can happen when using MSBuild SDK Extras etc. indirectly.

[peterhuene]

NETSDK1105: Windows desktop applications are only supported on .NET Core 3.0 or higher. and the expected build errors due to missing references.

I get the full list of .NET Core App target frameworks in the project properties (after reload).

[vatsan-madhavan]

NETSDK1105: Windows desktop applications are only supported on .NET Core 3.0 or higher. and the expected build errors due to missing references.

I get the full list of .NET Core App target frameworks in the project properties (after reload).

Perfect!

Thank you!

[peterhuene]

I'll review as soon as Nick gets back to me regarding what we want to do with the .NET Framework values.

[vatsan-madhavan]

/cc @merriemcgaw FYI.

[vatsan-madhavan]

@peterhuene, I've updated incorporating exclusions for netfx.