Fix for #1198 - fixes potential crashes in high-DPI applications #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Watson] clr20r3: CLR_EXCEPTION_System.Collections.Generic.KeyNotFoundException_80131577_PresentationCore.dll!MS.Internal.DpiUtil+DpiAwarenessScope..ctor -- When a caller passes in `dpiAwarenessContextValue==Invalid`, `new DpiAwarenessContextHandle(dpiAwarenssContextValue)` throws `KeyNotFoundException`. This happens because we do not have a pre-created pseudo-_HANDLE_ corresponding to `Invalid` in our internal map of pseudo-handles in `DpiAwarenessContextHandle.WellKnownContextValues`. Such a pseudo-handle cannot be created either. When `dpiAwarenessContextValue=Invalid` is passed, the correct behavior is to treat it as a no-op and simply `return`. The corresponding `Dispose()` will also run benignly and the caller will get the correct behavior - which is that no changes will be made to the thread-state.
ghost
requested review from
|
For reference, this is what a typical crash-stack will look like (this is a .NET Framework crash stack): |
vatsan-madhavan
added
the
tell-mode
rladuca
approved these changes
Aug 3, 2019
vatsan-madhavan
deleted the
dev/vatsan/dpiawarenesscontextvalue-crash-fix
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1198.
[Watson] clr20r3: CLR_EXCEPTION_System.Collections.Generic.KeyNotFoundException_80131577_PresentationCore.dll!MS.Internal.DpiUtil+DpiAwarenessScope..ctor
--
When a caller passes in
dpiAwarenessContextValue==Invalid,new DpiAwarenessContextHandle(dpiAwarenssContextValue)throwsKeyNotFoundException.This happens because we do not have a pre-created pseudo-HANDLE corresponding to
Invalidin our internal map of pseudo-handles inDpiAwarenessContextHandle.WellKnownContextValues. Such a pseudo-handle cannot be created either.When
dpiAwarenessContextValue=Invalidis passed, the correct behavior is to treat it as a no-op and simplyreturn. The correspondingDispose()will also run benignly and the caller will get the correct behavior - which is that no changes will be made to the thread-state.