Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MERGE] use a hacky way to run all the tests using new FileStream implementation #4756

Closed
wants to merge 1 commit into from

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Apr 1, 2021

Please ignore this PR, I just want to check if the most recent changes have not broken anything in WinForms before we enable them by default.

Microsoft Reviewers: Open in CodeFlow

@adamsitnik adamsitnik added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 1, 2021
@adamsitnik adamsitnik self-assigned this Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #4756 (aae8fef) into main (3b50903) will decrease coverage by 0.00752%.
The diff coverage is n/a.

❗ Current head aae8fef differs from pull request most recent head 859447b. Consider uploading reports for the commit 859447b to get more accurate results

@@                 Coverage Diff                 @@
##                main       #4756         +/-   ##
===================================================
- Coverage   97.96231%   97.95479%   -0.00752%     
===================================================
  Files            547         547                 
  Lines         266036      266036                 
  Branches        5109        5109                 
===================================================
- Hits          260615      260595         -20     
- Misses          4531        4547         +16     
- Partials         890         894          +4     
Flag Coverage Δ
Debug 97.95479% <ø> (-0.00752%) ⬇️
test 97.95479% <ø> (-0.00752%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@adamsitnik
Copy link
Member Author

The change in runtime repo (dotnet/runtime#50166) has been merged, I am closing the PR.

@adamsitnik adamsitnik closed this Apr 9, 2021
@ghost ghost added the draft draft PR label Sep 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
draft draft PR 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant