Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert https://github.com/dotnet/winforms/pull/7024 when the NUGET warning is fixed #7025

Closed
Tanya-Solyanik opened this issue Apr 15, 2022 · 2 comments · Fixed by #7410
Closed

revert https://github.com/dotnet/winforms/pull/7024 when the NUGET warning is fixed #7025

Tanya-Solyanik opened this issue Apr 15, 2022 · 2 comments · Fixed by #7410
Labels
area-Infrastructure

Comments

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Apr 15, 2022 •
edited
Loading

Revert #7024 when dotnet/sdk#24747 is fixed.

Issue description

NU1505 was disabled because it was causing the following output in the VS:

Warning	NU1505	Duplicate 'PackageDownload' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageDownload' items are: 

Microsoft.NETCore.App.Host.win-x64 [7.0.0-preview.4.22214.7], 
Microsoft.NETCore.App.Host.win-x64 [7.0.0-preview.4.22214.7],
Microsoft.NETCore.App.Host.win-x64 [7.0.0-preview.4.22214.7],
Microsoft.NETCore.App.Host.win-x64 [7.0.0-preview.4.22214.7].

AccessibilityTests	D:\winforms\src\System.Windows.Forms\tests\AccessibilityTests\AccessibilityTests.csproj

This warning was temporarily disabled in #7024, and should be re-enabled when the but is fixed.
@Tanya-Solyanik Tanya-Solyanik added untriaged The team needs to look at this issue in the next triage area-Infrastructure and removed untriaged The team needs to look at this issue in the next triage labels Apr 15, 2022
@dreddy-work
Copy link
Member

@Tanya-Solyanik , linked bug is closed. Can you push PR reverting the change?

@Tanya-Solyanik
Copy link
Member Author

This change did not make it into our repo yet

@Tanya-Solyanik Tanya-Solyanik mentioned this issue May 26, 2022
Closed
@ghost ghost added the 🚧 work in progress Work that is current in progress label May 26, 2022
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jun 6, 2022
@Tanya-Solyanik Tanya-Solyanik added this to the 7.0 RC1 milestone Jul 14, 2022
Tanya-Solyanik added a commit to Tanya-Solyanik/winforms that referenced this issue Jul 14, 2022
@Tanya-Solyanik
Fixes dotnet#7025
96cad8a 
This change re-enables nuget warnings that were reported mistakenly previously because fix for false positives reached VS2022.
@Tanya-Solyanik Tanya-Solyanik mentioned this issue Jul 14, 2022
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Jul 14, 2022
@ghost ghost removed this from the 7.0 RC1 milestone Jul 14, 2022
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jul 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
2 participants
@Tanya-Solyanik @dreddy-work