Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichTextBox link handling is broken #1644

Closed
RussKie opened this issue Aug 15, 2019 · 4 comments · Fixed by #1661
Closed

RichTextBox link handling is broken #1644

RussKie opened this issue Aug 15, 2019 · 4 comments · Fixed by #1661
Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework
Milestone
3.0-Preview9

Comments

@RussKie
Copy link
Member

RussKie commented Aug 15, 2019 •
edited
Loading

  • Have you experienced this same bug with .NET Framework?: No

Problem description:

RitchTextBox does not react to LinkClicked events at all.

Actual behavior:
Created two apps - .NET 4.6.1 and .NET Core side-by-side targeting msftedit.dll (not the old riched20.dll), loaded the same rtf:
rtb-link-issue

Expected behavior:

.NET Core reacts to the events like .NET Fx did.

Minimal repro:

https://github.com/RussKie/Test-RichTextBox-links
@RussKie RussKie added 🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework labels Aug 15, 2019
@RussKie RussKie modified the milestones: 3.0.0-Preview9, 3.0.0-GA Aug 15, 2019
@RussKie RussKie mentioned this issue Aug 16, 2019
Closed
@weltkante
Copy link
Contributor

weltkante commented Aug 16, 2019 •
edited
Loading

Move your initialization from constructor into load event then it works for me.

I think I'm starting to see a pattern here, with ComboBox (#1311) and ListView (#1607) not working when doing certain things in constructor initialization

@weltkante weltkante mentioned this issue Aug 16, 2019
Closed
@weltkante

This comment has been minimized.

Sign in to view
@JeremyKuhne JeremyKuhne mentioned this issue Aug 20, 2019
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Aug 20, 2019
RussKie pushed a commit to JeremyKuhne/winforms that referenced this issue Aug 20, 2019
@JeremyKuhne @RussKie
Properly add and remove reflect children
f91eb3b 
Fixes dotnet#1311
Fixes dotnet#1520
Fixes dotnet#1607
Fixes dotnet#1644

The bug was introduced as part of refactoring in dotnet#1034 - ordering got flipped with switching `as` to `is`.
The confusion was likely caused by the fact that the property setter called its own getter.

Update the code to be more explicit in terminology to hopefully avoid this from happening again.
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Aug 20, 2019
@RussKie RussKie modified the milestones: 3.0.0-GA, 3.0.0-Preview9 Aug 20, 2019
@Marie-Shi
Copy link

Verified this bug with .Net Core 3.0.100-preview9-014004 from release branch, this bug is fixed, please see the below screenshot:
LinkEvent
LinkEvent1

@RussKie
Copy link
Member Author

RussKie commented Aug 27, 2019

Thank you!

@RussKie RussKie mentioned this issue Apr 28, 2021
Merged
16 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🪲 bug Product bug (most likely) 💥 regression-preview Regression from a preview release tenet-compatibility Incompatibility with previous versions or with WinForms for .NET Framework
Projects
None yet
Milestone
3.0-Preview9
Development

Successfully merging a pull request may close this issue.

Properly add and remove reflect children JeremyKuhne/winforms
3 participants
@RussKie @weltkante @Marie-Shi