Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal build image #3328

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Update internal build image #3328

merged 3 commits into from
Dec 2, 2022

Conversation

akoeplinger
Copy link
Member

The build.windows.10.amd64.vs2019 image doesn't exist anymore, it was replaced by windows.vs2019.amd64

The `build.windows.10.amd64.vs2019` image doesn't exist anymore, it was replaced by `windows.vs2019.amd64`
@akoeplinger
Copy link
Member Author

note that this also affects release/6.0 and release/7.0 branches so it should probably be backported

@akoeplinger akoeplinger merged commit 8461d65 into main Dec 2, 2022
@akoeplinger akoeplinger deleted the fix-build-images branch December 2, 2022 14:06
@dreddy-work
Copy link
Member

@akoeplinger , what about pool name? I see following in 6.0 vs main in windows-build.yml. Also, its hard to track when the pool names and images are changing. Is there any central team or place to track on these changes?

   ${{ if eq(variables['System.TeamProject'], 'public') }}:
        name: NetCore-Svc-Public
        demands: ImageOverride -equals windows.vs2019.amd64.open
      ${{ if ne(variables['System.TeamProject'], 'public') }}:
        name: NetCore1ESPool-Svc-Internal
        demands: ImageOverride -equals windows.vs2019.amd64

vs

   ${{ if eq(variables['System.TeamProject'], 'public') }}:
        vmImage: 'windows-2019'
      ${{ if ne(variables['System.TeamProject'], 'public') }}:
        name: NetCore1ESPool-Internal
        demands: ImageOverride -equals windows.vs2019.amd64

@akoeplinger
Copy link
Member Author

You can subscribe to the dncpartners@ list where dnceng posts these types of changes. As far as I know every team is reponsible to apply the changes.

As for the pool names: the vmImage: windows-2019 means it is a public pool not managed by 1ES but by AzDO, you can use it for public builds.

For internal builds the main branch should use NetCore1ESPool-Internal while release or servicing branches should use NetCore1ESPool-Svc-Internal (mainly for budgeting/reporting reasons).

dreddy-work added a commit that referenced this pull request Dec 2, 2022
mmitche pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants