Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suppressing running the UpdatePRService steps #5654

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Sep 26, 2024

Converted the _RunWithCoreWcfService from a variable into a parameter. The variable defined on the pipeline definiton was being overwritten by the yml file so wasn't actually applying. If you look at existing CoreWCF runs in the run tests step, you'll see that _RunWithCoreWcfService is being set to false instead of the expecgted true.

The pipeline definition will need to be edited to remove the variable, instead it becomes a check box like shown here:
image

This can't be done until after this change is merged. I manually kicked off a dotnet-wcf-with-corewcf--ci pipeline run with this new parameter checked which validates this PR. It's the only way to apply the parameter before this is merged as the existing pipeline definition can't see the parameter as it's not merged, so can't be edited to check that box until post merge.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=820662&view=results

@mconnew mconnew force-pushed the TestingPipelineChanges branch 9 times, most recently from 03c1321 to 434229b Compare September 27, 2024 06:32
@mconnew mconnew force-pushed the TestingPipelineChanges branch from 434229b to 3e409d6 Compare September 27, 2024 18:43
@HongGit HongGit merged commit 2b6c543 into dotnet:main Sep 28, 2024
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants