Implement Mtom message encoding #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests failed because the test server had the wrong code installed. I suspect this might have been another test running in parallel. Trying again |
mconnew
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenMolloy
approved these changes
Aug 10, 2021
src/System.Private.ServiceModel/src/Internals/System/Xml/XmlConverter.cs
Show resolved
Hide resolved
src/System.Private.ServiceModel/src/Internals/System/Xml/XmlExceptionHelper.cs
Outdated
Show resolved
Hide resolved
| @@ -17,7 +16,7 @@ namespace System.ServiceModel.Channels | |||
| // If any of the const's are modified in this file, they must also be modified | |||
| // on the Internal.ServiceModel.Primitives contract and implementation assemblies. | |||
|
|
|||
| public static class EncoderDefaults | |||
| internal static class EncoderDefaults | |||
There was a problem hiding this comment.
Were these various EncoderDefaults public in a previous release? It looks like they've been public for a while, but not exposed in the ref assembly. I see they were not public in 4.8, but is there any concern bringing them back to internal?
There was a problem hiding this comment.
They shouldn't have been public in the first place. This is just some additional cleanup.
src/System.Private.ServiceModel/src/Internals/System/Xml/XmlMtomReader.cs
Show resolved
Hide resolved
src/System.Private.ServiceModel/src/Internals/System/Xml/XmlMtomWriter.cs
Outdated
Show resolved
Hide resolved
src/System.Private.ServiceModel/src/Internals/System/Xml/XmlMtomWriter.cs
Outdated
Show resolved
Hide resolved
HongGit
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1810