Adds an option to disable auto insert #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Sep 26, 2024
| @@ -732,6 +732,11 @@ | |||
| "title": "Text Editor", | |||
| "order": 1, | |||
| "properties": { | |||
| "dotnet.autoInsert.enableAutoInsert": { | |||
There was a problem hiding this comment.
Will auto insert be used for more than doc comments? Perhaps the settings should be dotnet.autoInsert.insertDocComments imagining that certain auto inserts might be disabled without disabling all auto inserts.
There was a problem hiding this comment.
If we do just want one big switch, then I would suggest dotnet.autoInsert.enabled
Cosifne
reviewed
Sep 26, 2024
| @@ -732,6 +732,11 @@ | |||
| "title": "Text Editor", | |||
| "order": 1, | |||
| "properties": { | |||
| "dotnet.autoInsert.enableAutoInsert": { | |||
There was a problem hiding this comment.
This needs to be covered by test.
https://github.com/dotnet/vscode-csharp/blob/main/test/lsptoolshost/unitTests/configurationMiddleware.test.ts
dibarbet
reviewed
Dec 4, 2024
|
/azp run dotnet.vscode-csharp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dibarbet
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn side fix: dotnet/roslyn#74485
To fix: #6349