Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog and test-plan for multiple download of omnisharp #2082

Merged
merged 9 commits into from
Mar 5, 2018
Merged

Update Changelog and test-plan for multiple download of omnisharp #2082

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4b5650
Update changelog and test-plan for multiple download of omnisharp
akshita31 Feb 28, 2018
149bb60
Merge branch 'master' into latestBuildDocumentation
akshita31 Mar 1, 2018
d3b488a
Changes
akshita31 Mar 1, 2018
f4723f9
Review Comments
akshita31 Mar 5, 2018
1dc8781
Code revie comments
akshita31 Mar 5, 2018
464e941
Changes
akshita31 Mar 5, 2018
714ea5d
Merge branch 'latestBuildDocumentation' of https://github.com/akshita…
akshita31 Mar 5, 2018
0f0ee52
Changed header
akshita31 Mar 5, 2018
2704ab7
Remove packages
akshita31 Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
* Adds launch.json option to suppress Just-In-Time compiler optimizations.
* Due to the previous two items and work from the .NET Team, it is now possible to easily debug into ASP.NET itself in projects running against .NET Core 2.1 preview 1. Support for debugging into all the managed code in .NET Core will come in future .NET Core 2.1 builds. Instructions are in the [wiki](https://github.com/OmniSharp/omnisharp-vscode/wiki/Debugging-into-the-.NET-Framework-itself).

#### Specify OmniSharp Version
Enables the use of pre-release builds of Omnisharp. Downloading a pre-release build of Omnisharp allows the C# extension for VS Code to use features that have been merged into the "master" branch of omnisharp-roslyn(https://github.com/OmniSharp/omnisharp-roslyn) but that have not been officially released
* Adds support to use the "omnisharp.path" option to download a specific copy of OmniSharp. The possible values for this option are:
* Some absolute path - Use a local copy of OmniSharp. The value must point to a directory which contains OmniSharp, typically a user's build output directory for the OmniSharp-Roslyn project. Example: C:\omnisharp-roslyn\artifacts\publish\OmniSharp.Stdio\win7-x64\OmniSharp.exe.
* "latest" - Use the latest CI build
* "<version>" - Use a specific version of OmniSharp. Example: `1.29.2-beta.60`

## 1.14.0 (February 14, 2018)

Expand Down
16 changes: 16 additions & 0 deletions test-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,22 @@ The easist way to verify that a project was successfully loaded is to open a .cs
* In a project that uses globbing (.NET Core), use the VS Code file explorer to add a new file next to the csproj. Intellisense/sighelp/etc should be available in the new file
* Add a new file and reference a type in it from a different file. Deleting from disk the file containing the referenced type should produce error messages

#### Omnisharp Options

#### omnisharp.useMono (for Linux)
For using this option, mono version greater than or equal to 5.2.0 must be installed. If that is not so, setting this option to true, should give an error.
* If the option is not set, the OmniSharp path displayed in the "OmniSharp Log" should end with "run"
* If the option is set, the OmniSharp path as mentioned above should end with "OmniSharp.exe"

#### omnisharp.path
Setting this path to any of the values as listed below, should start the OmniSharp server and display the correct OmniSharp path in the `OmniSharp Log`(View --> Output--> OmniSharp Log).
* undefined - OmniSharp server must start using the copy of omnisharp shipped with the extension, that is, the OmniSharp path must be the extension path, followed by .omnisharp followed by the platform-specific executable.
* Some absolute path - OmniSharp server must start using the local copy of OmniSharp pointed to by the path and the same must be displayed as the Omnisharp path. Example:C:\omnisharp-roslyn\artifacts\publish\OmniSharp.Stdio\win7-x64\OmniSharp.exe.
* "<version>" - The specified version packages must be downloaded and installed (The status of download/install can be seen in the `C#` log). If the installation is successful, the server must start and the OmniSharp path must include the .omnisharp/experimental folder followed by the version name and the executable. Eg: If the version is `1.29.2-beta.60`, the path displayed on Windows should be `.omnisharp/experimental/1.29.2-beta.60/OmniSharp.exe`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "version"--no "packages"

* "latest" - The file containing the information about the latest CI build (https://roslynomnisharp.blob.core.windows.net/releases/versioninfo.txt), must be downloaded and accordingly the latest CI build from the "master" branch of omnisharp-roslyn should be downloaded and installed. If the installation is successful, the server must start and the OmniSharp path must include the .omnisharp/experimental folder followed by the version name and the executable. Eg: If the latest version is `1.29.2-beta.62`, the path displayed on Windows should be `.omnisharp/experimental/1.29.2-beta.62/OmniSharp.exe`.
* All the above configurations should work, with and without setting the useMono option on Linux
* The above behavior should be exhibited when a new vscode window is opened, as well as if the setting is modified and a "Restart OmniSharp"(Ctrl+Shift+P --> OmniSharp: Restart OmniSharp) is performed.

[1] For example,
```
mkdir project
Expand Down