Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved generic method and parameters syntax highlighting #103

Closed
wants to merge 3 commits into from
Closed

Improved generic method and parameters syntax highlighting #103

wants to merge 3 commits into from

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Mar 17, 2016

Also fixes #89

Before:

image

After:

image

@ivanz ivanz changed the title Updated method name regex to handle generics. Fixes #89 Fixed an issue with generic method syntax highlighting (#89) Mar 17, 2016
@DustinCampbell
Copy link
Member

Looks great @ivanz. I'd love to take this PR. Since this is a PR to a Microsoft repo, let me get the machinery set up to take external PRs. I'll get the ball rolling on that today.

@ivanz ivanz changed the title Fixed an issue with generic method syntax highlighting (#89) Improved generic method and parameters syntax highlighting Mar 20, 2016
@ivanz
Copy link
Contributor Author

ivanz commented Mar 20, 2016

I made some more improvements to handle generic parameters in the method signature and also handle arrays of nullable types:

Before

image

After

image

@DustinCampbell
Copy link
Member

FWIW, I'm still waiting for the CLA machinery to get set up. It's being worked on though. Once it's ready, would you be willing to sign a Microsoft CLA? (assuming you haven't already)

@ivanz
Copy link
Contributor Author

ivanz commented Mar 24, 2016

Yes no problem whatsoever. I have signed one before.

@dnfclas
Copy link

dnfclas commented Apr 15, 2016

Hi @ivanz, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@DustinCampbell
Copy link
Member

Hi @ivanz, sorry for the delay! The CLA automation is finally set up. We're currently locked down on the master branch. I'll go ahead and rebase for you against dev.

@DustinCampbell
Copy link
Member

OK -- I've rebased against dev and created a new PR - #191. Thanks @ivanz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Syntax highlighting issue
3 participants