Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting incorrect for multi-dimensional arrays in parameter list. #657

Closed
seraku24 opened this issue Aug 13, 2016 · 1 comment

Comments

@seraku24
Copy link
Contributor

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.0-preview2-003121)

Product Information:
 Version:            1.0.0-preview2-003121
 Commit SHA-1 hash:  1e9d529bc5

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.10586
 OS Platform: Windows
 RID:         win10-x64

VS Code version: 1.4.0
C# Extension version: 1.3.0

Steps to reproduce

  1. Use a multi-dimensional array (e.g. int[,]) as the type for an argument to a function.

Expected behavior

The type and parameter name should be properly colored like other parameters.

Actual behavior

vscode-syntaxhighlightingissue

Note that both the type and parameter name for redFish are in the default coloring. I originally suspected the presence of a comma in a type might be the culprit, however the templated argument ham is rendered as expected.

ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 17, 2016
… [ , ]", etc properly inside method parameter list.

Fixes dotnet#657
seraku24 added a commit to seraku24/omnisharp-vscode that referenced this issue Aug 18, 2016
Fixes (again) dotnet#657 as well as issues brought up in dotnet#670.

- Corrects the order of type, template arguments, nullable type specification and array specifications.
- Ensures array specification support all forms (simple arrays, multi-dimensional arrays, arrays of arrays).
@seraku24
Copy link
Contributor Author

@DustinCampbell, would you be able to re-open this issue while my pull request is being considered? Or would you prefer that I open a new issue and just reference this one? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants