Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose session related APIs for SparkSession. #266

Merged
merged 7 commits into from
Sep 25, 2019

Conversation

imback82
Copy link
Contributor

Expose session related APIs for SparkSession such Active(), SetActiveSession(), etc.


using Microsoft.Spark.Interop.Ipc;

namespace Microsoft.Spark.Interop.Scala
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it supposed to be Microsoft.Spark.Interop.Scala or Microsoft.Spark.Internal.Scala

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have been Microsoft.Spark.Interop.Internal.* I moved the existing ones as well.

Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imback82 imback82 self-assigned this Sep 25, 2019
@imback82 imback82 added the enhancement New feature or request label Sep 25, 2019
@imback82 imback82 merged commit 047a547 into dotnet:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants