Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vstest depends on Desktop assemblies to build localized bits #96

Closed
karajas opened this issue Aug 9, 2017 · 11 comments
Closed

Vstest depends on Desktop assemblies to build localized bits #96

karajas opened this issue Aug 9, 2017 · 11 comments
Assignees
@crummel
Labels
area-product-experience Improvements in the end-user's product experience

Comments

@karajas
Copy link
Member

karajas commented Aug 9, 2017 •
edited
Loading

dotnet/sdk#335

The TestHost folder is missing from the output. It has the different localized bits of the Microsoft.TestPlatform.CLI assemblies that are produced in the Microsoft/vstest repo.
@omajid
Copy link
Member

omajid commented Aug 11, 2017

There was a question whether this is desired at all. It could be that TestHost leaking into the SDK build is an accident.

@omajid
Copy link
Member

omajid commented Aug 21, 2017

@dleeapho Hey, did we ever confirm whether TestHost bits are meant to be included or not?

@karajas
Copy link
Member Author

karajas commented Aug 23, 2017

@nguerrera Thoughts?

@nguerrera
Copy link
Contributor

nguerrera commented Aug 23, 2017 •
edited
Loading

As I indicated on the offline thread, vstest folks need to answer this. @codito, @sbaid

@karajas
Copy link
Member Author

karajas commented Aug 23, 2017

Thanks! wasn't sure who to tag.

@omajid
Copy link
Member

omajid commented Aug 24, 2017

@dleeapho mentioned Testhost should not be part of SDK.

@dleeapho
Copy link
Contributor

dleeapho commented Oct 6, 2017

Related to #125

@codito codito mentioned this issue Oct 31, 2017
Merged
5 tasks
codito pushed a commit to codito/dotnet-source-build that referenced this issue Nov 15, 2017
Add repo api support for vstest repo.
edfff45 
Fix dotnet#178 dotnet#96
@codito codito mentioned this issue Nov 15, 2017
Merged
dseefeld pushed a commit that referenced this issue Nov 27, 2017
@codito @dseefeld
Add repo api support for vstest repo. (#289)
06dd9c6 
* Add repo api support for vstest repo.

Fix #178 #96

* Update vstest repo to 92c73db.

* Explicitly enable DotnetSourceBuild and provide path to dotnet-cli.
@dseefeld dseefeld added the area-prebuilts Reducing the number of prebuilt packages in the tarball label May 23, 2018
@dseefeld dseefeld assigned crummel and unassigned dseefeld May 23, 2018
@crummel
Copy link
Contributor

crummel commented May 23, 2018

Verified that TestHost and associated resource DLLs are still making it into the final product and we appear to still be grabbing net451 packages to make this happen, although none of those make it into the final output themselves. Taking myself off this assignment for now since I'm FR the next two weeks.

@crummel crummel removed their assignment May 23, 2018
@crummel crummel removed the triaged label Aug 29, 2018
@crummel
Copy link
Contributor

crummel commented Aug 29, 2018

Removed triaged to bring this back up from #708: the official SDK is including the TestHost - should we be or are they incorrect in doing so? We also in general know how to deal with required full-framework assemblies now (add the TargetingPack in their build).

@crummel crummel mentioned this issue Aug 29, 2018
Closed
@codito
Copy link
Contributor

codito commented Aug 30, 2018

looping in vstest folks @mayankbansal018 @smadala @cltshivash

@dseefeld dseefeld added triaged area-product-experience Improvements in the end-user's product experience and removed area-prebuilts Reducing the number of prebuilt packages in the tarball labels Sep 6, 2018
@MichaelSimons
Copy link
Member

[Triage] Closing this issue in favor of tracking with #3014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crummel crummel

Labels
area-product-experience Improvements in the end-user's product experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@codito @nguerrera @omajid @dseefeld @crummel @MichaelSimons @dleeapho @karajas