Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove linker repo from source-build #3199

Closed
3 tasks done
MichaelSimons opened this issue Jan 6, 2023 · 3 comments · Fixed by dotnet/dotnet#21
Closed
3 tasks done

Remove linker repo from source-build #3199

MichaelSimons opened this issue Jan 6, 2023 · 3 comments · Fixed by dotnet/dotnet#21
Assignees
@MichaelSimons
Labels
area-additional-repos Adding additional contributing repos up-for-grabs

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Jan 6, 2023 •
edited
Loading

The linker repo is being moved into runtime - dotnet/runtime#75278. As a result, linker should be removed from source-build.

  • Remove linker source-build project
  • Remove linker project references within source-build
  • Remove linker VMR source-mappings
@dotnet-issue-labeler dotnet-issue-labeler bot added area-additional-repos Adding additional contributing repos untriaged labels Jan 6, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Backlog in .NET Source Build Jan 9, 2023
@mthalman mthalman self-assigned this Jan 19, 2023
@mthalman mthalman moved this from 8.0 Backlog to In Progress in .NET Source Build Jan 19, 2023
@mthalman mthalman moved this from In Progress to 8.0 Backlog in .NET Source Build Jan 20, 2023
@MichaelSimons
Copy link
Member Author

MichaelSimons commented Feb 7, 2023 •
edited
Loading

These items were done with dotnet/installer#15389

@MichaelSimons
Copy link
Member Author

@premun - am I correct in my understanding that a VMR PR needs to be opened to remove the src/Linker directory?

@MichaelSimons MichaelSimons self-assigned this Feb 7, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to In Progress in .NET Source Build Feb 7, 2023
@premun
Copy link
Member

premun commented Feb 7, 2023

@MichaelSimons yes

@MichaelSimons MichaelSimons mentioned this issue Feb 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Feb 7, 2023
premun pushed a commit to dotnet/dotnet that referenced this issue Feb 7, 2023
@MichaelSimons
Remove linker repo (#21)
0a4d2a7 
Fixes dotnet/source-build#3199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-additional-repos Adding additional contributing repos up-for-grabs
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove linker repo MichaelSimons/dotnet
3 participants
@premun @MichaelSimons @mthalman