Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Newtonsoft 13.0.1 referenced to 13.0.3 #805

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update Newtonsoft 13.0.1 referenced to 13.0.3 #805

merged 6 commits into from
Nov 6, 2023

Conversation

MichaelSimons
Copy link
Member

Update Newtonsoft 13.0.1 referenced to 13.0.3 to prevent online only prebuilts. This is fallout from dotnet/source-build-externals#195.

@MichaelSimons
Copy link
Member Author

FYI, in 9.0 we now have a check to fail online builds if they have prebuilts. This would have caught this.

@ViktorHofer
Copy link
Member

The failure says there's still a Newtonsoft.Json/13.0.1 in the dependency graph. Do you need help with identifying the project that brings it in? The project.assets.json file should tell.

@MichaelSimons
Copy link
Member Author

The failure says there's still a Newtonsoft.Json/13.0.1 in the dependency graph. Do you need help with identifying the project that brings it in? The project.assets.json file should tell.

This is a nuget restore source issue in online builds, not a problem with the actual SBRP packages. This wouldn't be an issue if we have proper project dependencies and no n-1 SBRP packages around.

@MichaelSimons MichaelSimons merged commit fa4c0e8 into dotnet:release/8.0 Nov 6, 2023
@MichaelSimons MichaelSimons deleted the update-newtonsoft branch November 6, 2023 15:00
@MichaelSimons
Copy link
Member Author

/backport to main

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Started backporting to main: https://github.com/dotnet/source-build-reference-packages/actions/runs/6772550820

@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@mmitche mmitche mmitche approved these changes

@mthalman mthalman mthalman approved these changes

@oleksandr-didyk oleksandr-didyk oleksandr-didyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelSimons @ViktorHofer @mmitche @mthalman @oleksandr-didyk