Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.IdentityModel dependencies #194

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

eerhardt
Copy link
Member

Update to 7.0.0-preview3

cc @captainsafia @jennyf19

@eerhardt
Copy link
Member Author

@MichaelSimons @mthalman - This change will need to get into 8.0-rc2 (it is too late to get it into rc1). I'm not sure when the timing of this change can happen, since it doesn't appear that source-build-externals has an 8.0 branch.

@mthalman
Copy link
Member

It's reporting prebuilts for:

Microsoft.CSharp.4.5.0
System.Security.Cryptography.Cng.4.5.0

These will need to be added to SBRP.

@eerhardt
Copy link
Member Author

It's reporting prebuilts for:

Microsoft.CSharp.4.5.0
System.Security.Cryptography.Cng.4.5.0

These will need to be added to SBRP.

I thought it wasn't going to care about those 2 packages, since they are not used to build for net8.0. But I guess I was wrong.

I've updated the versions to what we used in 8.0-preview7. So we shouldn't need to touch SBRP.

@MichaelSimons
Copy link
Member

@MichaelSimons @mthalman - This change will need to get into 8.0-rc2 (it is too late to get it into rc1). I'm not sure when the timing of this change can happen, since it doesn't appear that source-build-externals has an 8.0 branch.

Is this pressing? I would prefer to wait a few more day until we have an rc1 build.

@eerhardt
Copy link
Member Author

Is this pressing? I would prefer to wait a few more day until we have an rc1 build.

It's critical to get this into rc2 by the time it ships. We can wait a few days, if necessary. But I don't want to push it until rc1 ships because that is the same time rc2 locks down.

Just an FYI - we will be doing this at least 1 more time before we ship 8.0 GA, because IdentityModel will need to release a stable 7.0.0 version, which .NET 8.0 will depend on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants