Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IdentityModel submodule to preview2 #187

Closed
wants to merge 3 commits into from

Conversation

jennyf19
Copy link

No description provided.

@jennyf19 jennyf19 changed the title Jennyf/i mpreview2 Update IdentityModel submodule to preview2 Aug 14, 2023
@mthalman
Copy link
Member

@jennyf19 - Looks like this causes a prebuilt for Newtonsoft.Json.13.0.3. This version of that package needs to be added to https://github.com/dotnet/source-build-reference-packages. You can follow the instructions in the README there for how to do that. Once the PR for that gets merged, it will produce a new version of the SBRP package that will get merged into this repo. Once that happens, we can incorporate that change into this PR and we should be good.

@MichaelSimons
Copy link
Member

@jennyf19 - Looks like this causes a prebuilt for Newtonsoft.Json.13.0.3. This version of that package needs to be added to https://github.com/dotnet/source-build-reference-packages. You can follow the instructions in the README there for how to do that. Once the PR for that gets merged, it will produce a new version of the SBRP package that will get merged into this repo. Once that happens, we can incorporate that change into this PR and we should be good.

I think a better solution is to upgrade the version we are source-building to be 13.0.3. There appear to be several repo on this version already (razor, fsharp, roslyn, etc). We are source-build 13.0.1. This repo resides in https://github.com/dotnet/source-build-externals but the upgrade should be done in a stand-alone PR.

@mthalman
Copy link
Member

I think a better solution is to upgrade the version we are source-building to be 13.0.3.

I'll take care of that.

@jennyf19
Copy link
Author

closing as we cannot ship w/this dependency. We will open another one once we have newtonsoft completely removed. Thanks for your help today @mthalman

@jennyf19 jennyf19 closed this Aug 15, 2023
@MichaelSimons
Copy link
Member

closing as we cannot ship w/this dependency. We will open another one once we have newtonsoft completely removed.

@jennyf19 - what is the backstory here? I'm curious why this dependency can't be shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants