Update SDK projects to use MSBuild Sdk attribute, and hence the version of the Sdk that ships with the CLI or VS #659
Conversation
|
Let's switch this to master. |
…on of the Sdk that ships with the CLI or VS
dsplaisted
force-pushed
the
update-stage0-sdk
branch
from
64efc18 to
02aa647
Compare
|
@dotnet-bot test Ubuntu14.04 Debug please |
|
@dotnet-bot test Windows_NT Debug please |
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="all.asset.types.portable.deps.json"> | ||
| <None Update="all.asset.types.portable.deps.json"> |
There was a problem hiding this comment.
Update [](start = 10, length = 6)
What does Update mean here?
| @@ -37,11 +26,6 @@ | |||
| </PackageReference> | |||
There was a problem hiding this comment.
Can we make Version an attribute for some of these package references?
|
This broke the signed build when I did it as part of the loc change that got reverted. Check that you're not getting default signassembly=false and do a test signed build pre merge. |
|
Also check that intermediate output path remains redirected. |
|
Once you verify the signed build, merge it in since it's an infrastructure change. |
|
Another thing was Jenkins builds failing often due to presumed arrival of #475 -- seems nobody is seeing that anymore (and it's closed due to that). Just make sure the CLI we use has recent bits. |
|
Discussed offline with Daniel. Closing as the same change is part of the loc change that needs to be reapplied and we don't want merge conflicts. |
…0190524.6 (dotnet#659) - Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview6-19274-06 - Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview6-19274-06
In addition to cleaning our project files up and dogfooding a recent version of the SDK, this fixes the design-time build and hence intellisense in VS for me on the latest builds of VS.