Finish localization of SDK #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move raw build task output to Raw\ subfolder to clean up the output directory structure and allow wildcarding without picking up things from tests or packages layout
We need to build with a newer SDK to correctly sign satellite assemblies
|
@dotnet-bot Test Windows_NT Release please This appears to be #475 |
srivatsn
approved these changes
Jan 11, 2017
|
@MattGertz for approval |
Conflicts: src/VsixV3/Microsoft.Net.Sdk.swr
natidea
reviewed
Jan 11, 2017
| @@ -4,7 +4,20 @@ | |||
| "certificate": "Microsoft402", | |||
| "strongName": "MsSharedLib72", | |||
| "values": [ | |||
| "Microsoft.NET.Build.Tasks.dll" | |||
| "Raw/Microsoft.NET.Build.Tasks.dll", | |||
There was a problem hiding this comment.
Microsoft.NET.Build.Tasks.dll [](start = 21, length = 29)
So did the location of this DLL move, or is it in both places? Did you check that it is still packaged properly etc.
natidea
approved these changes
Jan 11, 2017
|
Approved to merge |
333fred
added a commit
to 333fred/sdk
that referenced
this pull request
Jan 19, 2017
* dotnet/master: (38 commits) Remove workaround for VB compiler since the bug's been fixed. Pass the correct delimiter for DefineConstants for C# and VB Rename ResolvePackageReferencesDesignTime to CollectPackageReferences Add Missing Dependency Facades to SDK package Run PackageReference de-dupe target before ResolvePackageReferencesDesignTime so that VS can get de-duped list Switch back to deduplicating implicit PackageReference items in a target instead of in evaluation Add implicitly expanded design time facades to deps.json for PreserveCompilationContext Remove TODO and outdated comment Add inference logic for RuntimeFrameworkVersion and implicit package reference for Microsoft.NETCore.App Update test sdk version. Fix for source navigation in netcoreapp1.0 projects. Deduplicate implicit package references in evaluation instead of a target Move implicit PackageReference logic to DefaultItems.props and DefaultItems.targets Update link for more information on implicit PackageReference items Add warning message for when projects override implicit PackageReference items Allow projects to override implicit PackageReference items with item Include syntax Add aka.ms link for more information on implicit items Simplify duplicate item error message to be one resource string, only generate error if implicit items are enabled Revert "Merge pull request dotnet#626 from nguerrera/satellites" Add test for explicitly including an item from a folder excluded from the implicit item includes Put "packages" back in list of folders to be excluded from implicit items ...
nguerrera
added a commit
to nguerrera/sdk
that referenced
this pull request
Feb 1, 2017
This reverts commit 1ac0ffd. Conflicts: src/Tasks/Microsoft.NET.Build.Tasks/Resources/xlf/Strings.xlf src/VsixV3/Microsoft.Net.Sdk.swr
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…425.5 (dotnet#626) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and deploy satellites from translations
The satellites are still not being picked up correctly by core MSBuild, but they work with desktop MSBuild. I am still investigating but I believe this is due to dotnet/msbuild#1476.
Change the target SatelliteDllsProjectOutputGroup to SatelliteDllsProjectOutputGroupWithFinalOutputPath, which will include the resources from the final output path rather than the intermediate path and hence will include the signed satellite assemblies
Customer scenario
Build messages from the SDK will not be localized without this change
Bugs this fixes:
SDK portion of VSO 279745
(The project system portion was already completed before entering escrow)
Workarounds, if any
None
Risk
Low
Performance impact
None for English. Only the required small impact of loading satellite assembly for non-English languages.
Is this a regression from a previous update?
No. This was feature work approved to be done by RC3.
How was this bug found?
N/A. This was known work that wasn't done until now.
@srivatsn @dotnet/project-system