Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/msbuild #47181

Merged
merged 4 commits into from
Mar 3, 2025
Merged

[main] Update dependencies from dotnet/msbuild #47181

merged 4 commits into from
Mar 3, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 28, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
7e57922 
…0227.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25127-07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Feb 28, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/msbuild:

@dotnet/kitten

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/msbuild) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@v-wuzhai
Copy link
Member

v-wuzhai commented Feb 28, 2025 •
edited
Loading

@dotnet/msbuild-admins @edvilme There are some test failures, with the following error message:

StdOut:
C:\h\w\AC0E0909\t\dotnetSdkTests\czgewqkf.lgs\WhenNestedPro---C833F2A1\App.sln : Solution file error MSB5004: The solution file has two projects named "foo".

Looks like the issue is caused by having two projects named "foo" in the solution file, leading to a conflict. Could you please take a look at this issue? Thanks!

The error here is the same as in #47184.

@edvilme
Copy link
Member

edvilme commented Feb 28, 2025

Hello. Yes, this is a regression that was introduced by vs-solutionpersistence, but was later addressed.
Updating should fix the issue. Will take a look tomorrow morning.

@JanProvaznik
Copy link
Member

JanProvaznik commented Feb 28, 2025 •
edited
Loading

We reverted usage of slnx library parsing sln in MSBuild dotnet/msbuild#11488. The test should be skipped.

@joeloff joeloff mentioned this pull request Feb 28, 2025
Merged
@edvilme
Copy link
Member

edvilme commented Feb 28, 2025 •
edited
Loading

This regression should be fixed by microsoft/vs-solutionpersistence#101 so we should take a look again once they release the new version

dotnet-maestro bot and others added 2 commits March 1, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
82cbabe 
…0228.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25128-02
@akoeplinger
Disable tests that rely on vs-solutionpersistence fix
595df90
@build-analysis build-analysis bot mentioned this pull request Mar 1, 2025
Open
3 tasks
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
81b9204 
…0303.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25126-06 -> To Version 17.14.0-preview-25153-01
@v-wuzhai
Copy link
Member

v-wuzhai commented Mar 3, 2025

/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Mar 3, 2025
Open
3 tasks
@dotnet-maestro dotnet-maestro bot merged commit 35f1e9c into main Mar 3, 2025
43 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-596ce672-c629-4296-830f-a9563c2d99ca branch March 3, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @edvilme @JanProvaznik @akoeplinger