Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to
dotnet-test
related files, focusing on improvements to test handling and updating patterns for better consistency and reliability. The most important changes include updates to test methods, adjustments to file paths, and the removal of unnecessary code.Test Method Updates:
[Theory]
with[InlineData]
to[Fact]
and removed configuration parameters for simplicity. (test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestBasedOnGlobbingFilter.cs
) [1] [2]File Path Adjustments:
Path.DirectorySeparatorChar
for better cross-platform compatibility. (test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestBasedOnGlobbingFilter.cs
)test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestBasedOnGlobbingFilter.cs
)Code Cleanup:
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestBasedOnGlobbingFilter.cs
)Compile
directive from the project file. (test/dotnet.Tests/dotnet.Tests.csproj
)Consistency Improvements:
TestingConstants
for better maintainability. (test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTests.cs
,test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
) [1] [2] [3] [4]Pattern Matching:
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestBasedOnGlobbingFilter.cs
)These changes aim to improve the reliability and maintainability of the test suite by simplifying test methods, ensuring cross-platform compatibility, and using consistent patterns and constants.
Relates to #45927