Implement workaround for Aspire dashboard launching #46100
Merged
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-AspNetCore
|
Thanks for your PR, @tmat. |
This was referenced Jan 18, 2025
Open
davidfowl
added
Servicing-consider
and removed
untriaged
|
We want this in 9.0.2xx for aspire @marcpopMSFT, just a heads up. |
tmat
force-pushed
the
AspireBrowserLaunch
branch
from
7a3e8b1 to
8a8df71
Compare
phil-allen-msft
approved these changes
Jan 21, 2025
|
merge commit was a comment and built passed. Merging. |
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #44262.
Context
The change fixes browser launching for Aspire projects in dotnet watch. Aspire application is expected to launch browser on dashboard URL that contains auth token, but the standard dotnet-watch browser launching implementation launches browser without the token.
Customer impact
Aspire application run via dotnet-watch doesn't open dashboard page in the browser.
Details
The fix implements a simple workaround: it scans the output of the app host for the full dashboard URL.
The proper fix would be to add DCP protocol request that instructs IDE to launch browser at specified URL. This approach would avoid adding Aspire specific logic to launch profile processing. See dotnet/aspire#7197.
We should also
a) Move VS implementation of profile processing to a shared library/source package in SDK, so that we can share the logic between VS, VS Code and dotnet-run
b) Implement browser launching in dotnet run (#9038) and use [a] to process launch profile
Changes made
Special cases Aspire project in existing URL scanning code.
Testing
Manual testing to confirm that the changes correctly open the dashboard in the browser.
Risks
Small potential risk of breaking URL scanning, although this has been mitigated by added tests.