Use Build.ArtifactStagingDirectory now that we run with native contai… #45428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ners in AzDO Before when we running with a custom docker invocation we couldn't write to files outside of the mount. Now that we use the native AzDO container integration that shouldn't be an issue anymore.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
mmitche
approved these changes
Dec 12, 2024
| @@ -455,6 +454,7 @@ jobs: | |||
| customPreBuildArgs='' | |||
| customBuildArgs='' | |||
| extraBuildProperties='' | |||
| customBuildArgs="--ci --prepareMachine -c ${{ parameters.configuration }}" | |||
There was a problem hiding this comment.
How is this change related? Also why wasn't this just done two lines above?
There was a problem hiding this comment.
Copy / Paste error, I should have replaced L455 instead. It doesn't cause any issues but I will clean this up when I touch the file again. Thanks for pointing it out.
Unrelated change. I noticed that the Unix test invocation didn't receive these expected arguments. I didn't want to spin a new with PR just for this one liner to save resources.
There was a problem hiding this comment.
I just wanted to understand the relation. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ners in AzDO
Before when we running with a custom docker invocation we couldn't write to files outside of the mount. Now that we use the native AzDO container integration that shouldn't be an issue anymore.