Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest artifacts reading #45407

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Fix manifest artifacts reading #45407

merged 5 commits into from
Dec 12, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Dec 10, 2024

Hide whitespace changes when reviewing

Fixes the failures in https://dev.azure.com/dnceng/internal/_build/results?buildId=2598401&view=logs&j=012d8f49-bbe9-5cff-0c2d-eb37469742f3&t=a088a11a-052c-5a48-307b-2470eb67bf36

Artifacts were missing from the payload folders because they accidentally got filtered out by the GetKnownArtifactsFromAssetManifests task.

Pass a custom equality comparer in so that Distinct actually compares the ItemSpec and the Version metadata instead of just reference equality.

Also change the ShouldIncludeElement method to not filter out when an empty RepoOrigin string is passed in.

Pass a custom equality comparer in so that Distinct actually compares the ItemSpec and the Version metadata instead of just reference equality.

Also change the ShouldIncludeElement method to not filter out when an empty RepoOrigin string is passed in.
@ViktorHofer ViktorHofer requested review from a team as code owners December 10, 2024 22:40
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 10, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) December 10, 2024 22:44
@ViktorHofer ViktorHofer merged commit 5839388 into main Dec 12, 2024
38 checks passed
@ViktorHofer ViktorHofer deleted the GetKnownArtifactsFix branch December 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants