[main] Update dependencies from dotnet/msbuild

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

• Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
• Build: 20241204.4
• Date Produced: December 4, 2024 10:24:22 AM UTC
• Commit: 5491064fe8d18c8f73d8b6048d277c3ec8b81d31
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.msbuild: from 17.13.0-preview-24568-05 to 17.13.0-preview-24604-04
  • Microsoft.Build: from 17.13.0-preview-24568-05 to 17.13.0-preview-24604-04
  • Microsoft.Build.Localization: from 17.13.0-preview-24568-05 to 17.13.0-preview-24604-04

[nagilson]

@dotnet/msbuild-admins ILLink_can_treat_warnings_not_as_errors is failing and some other warning/error related tests, and it looks like you may have changed some warning code dotnet/msbuild@37fc828...e73ffcb. May you PTAL? @surayya-MS @JanKrivanek @JanProvaznik

[JanKrivanek]

FYI @SimaTian - possible warnaserror impact?

[SimaTian]

Hello, the ILLink is using the WarningAsErrors property for their own purposes.
#12601 (comment)
Until this point this caused no issues due to the way MSBuild handled these, but now that we moved the parsing to the engine level, it clashed with their "overload".
I will revert the change in Main for now, so that we're not blocking msbuild->sdk merges and we'll take it from there.

[SimaTian]

After some further discussion we've decided against reverting. I will disable the tests for now and create a follow up issue to handle them.

[nagilson]

@dotnet/msbuild-admins Thank you and @SimaTian for following up.

There is a new problem with analyzers. I think this might be on msbuild to look into.

error : The .NET SDK has newer analyzers with version '10.0.0' than what version '5.0.3' of 'Microsoft.CodeAnalysis.NetAnalyzers' package provides. Update or remove this package reference. [/datadisks/disk1/work/AB970987/w/AFD10983/e/testExecutionDirectory/AnalyzersAreC---4DE360D4/AnalyzersAreConflictResolved/AnalyzersAreConflictResolved.csproj]
AnalyzersAreConflictResolved -> /datadisks/disk1/work/AB970987/w/AFD10983/e/testExecutionDirectory/AnalyzersAreC---4DE360D4/AnalyzersAreConflictResolved/bin/Debug/net10.0/AnalyzersAreConflictResolved.dll

[surayya-MS]

looking into this

[surayya-MS]

I couldn't find Microsoft.CodeAnalysis.NetAnalyzers in msbuild repo.

The failed test is Microsoft.NET.Build.Tests.GivenThatWeWantToResolveConflicts.AnalyzersAreConflictResolved. @nagilson could this be the problem?

sdk/test/Microsoft.NET.Build.Tests/GivenThatWeWantToResolveConflicts.cs

Line 233 in d7d440b

testProject.PackageReferences.Add(new TestPackageReference("Microsoft.CodeAnalysis.NetAnalyzers", "5.0.3"));

[surayya-MS]

scratch that. here is the problem

sdk/test/Microsoft.NET.Build.Tests/GivenThatWeWantToResolveConflicts.cs

Line 243 in d7d440b

itemGroup.Add(new XElement(ns + "TreatWarningsAsErrors", "true"));

@SimaTian this is related to the same change dotnet/msbuild@4dff69f

[surayya-MS]

We've decided to revert the change dotnet/msbuild@4dff69f to unblock this PR

[surayya-MS]

Microsoft.NET.Build.Tests.GivenThatWeWantMSBuildToRespectCustomCulture.SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldFail test fails

@JanKrivanek could this be related to dotnet/msbuild@04ef516 ?

[JanKrivanek]

FullFW Msbuild tests are still on 17.12 - se separating the test case for it temporarily

[nagilson]

Now, GivenThatWeWantMSBuildToRespectCustomCulture is failing.