[release/9.0.2xx] Change from "sln" to "solution" as primary, and add "sln" as alias #44203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…" to a shorthand alias. Additional changes have been made to tests that relied on certain outputs using "sln" and hard-baked calls to "sln" from internal code.
…ngs downstream expecting SLN such as aspire, etc? Will need someone with more knowledge to check if this could affect things downstream.
…l command options
github-actions
bot
requested review from
tmat,
arunchndr and
a team
as code owners
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
nagilson
added
Servicing-consider
and removed
untriaged
nagilson
approved these changes
Oct 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dotnet slnnow works withdotnet solutionwhich is part of a greater effort and being backported due to expected futureslnxwork in .NET.This was contributed by an open-source community member to main and we are backporting because of this.
Testing
Additional unit tests to verify the changes to support
dotnet solutionanddotnet slntests were kept in place and manual testing of customer PR.Risk
Low - adds a new alias to the sln command.
Regression
No
Customer Impact
Allows customers to use a new alias to dotnet sln as dotnet solution and will help when dotnet slnx support is added though that is not added in 9.0.2xx yet so it could wait until the next release.
Backport of #43607 to release/9.0.2xx
/cc @nagilson @SourceCodeWhen