Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Update dependencies from dotnet/runtime #43554

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 18, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: fbe40687-4477-491b-ebc0-08dcbc3038ad
  • Build: 20240923.2
  • Date Produced: September 23, 2024 9:21:15 PM UTC
  • Commit: 3d9da91a9720f7bda3e4cef127b8195441fb2580
  • Branch: refs/heads/release/9.0

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-rc.2.24464.3 to 9.0.0-rtm.24469.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-rc.2.24464.3 to 9.0.0-rtm.24469.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

…0917.13

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rc.2.24466.12 -> To Version 9.0.0-rtm.24467.13
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@jeffschwMSFT
Copy link
Member

thanks @lewing, thoughts on this issue?

The command "D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\dotnet workload update --from-rollback-file D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\TestRollback.json" exited with code 1.

@lewing
Copy link
Member

lewing commented Sep 18, 2024

thanks @lewing, thoughts on this issue?

The command "D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\dotnet workload update --from-rollback-file D:\a_work\1\s\artifacts\bin\redist\Release\dotnet\TestRollback.json" exited with code 1.

still working on it, jumping between multiple issues atm

@lewing
Copy link
Member

lewing commented Sep 18, 2024

@jeffschwMSFT the current issue appears to be caused by #37160 which is used when parsing the rollback file and is setting the version to 9.0.0 which doesn't exist until the package version is actually stabilized.

cc @Forgind @dsplaisted @marcpopMSFT

@lewing
Copy link
Member

lewing commented Sep 18, 2024

It might make sense to change the authoring side to drop -rtm from the sdk band version always, not just when the versions are stable and fix the regexes to drop it as well.

@lewing
Copy link
Member

lewing commented Sep 18, 2024

It might make sense to change the authoring side to drop -rtm from the sdk band version always, not just when the versions are stable and fix the regexes to drop it as well.

This seems like the path least likely to cause churn when we stabilize so I will update emsdk and runtime to do this and then fix sdk here once the flow reaches here.

@lewing
Copy link
Member

lewing commented Sep 18, 2024

@lewing
Copy link
Member

lewing commented Sep 18, 2024

(this will obviously be red until there is flow)

@marcpopMSFT
Copy link
Member

I think your solution is probably the right one. the -rtm versions end up having no pre-release label and usually aren't stable until the last minute so we end up with a window where workloads don't know what feature band to use when it's a -rtm SDK. Treating -rtm special seems like the right solution for now.

@@ -363,11 +363,11 @@
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportPackageVersion>9.0.0-rc.2.24464.3</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportPackageVersion>
<EmscriptenWorkloadManifestVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportPackageVersion)</EmscriptenWorkloadManifestVersion>
<!-- emsdk workload prerelease version band must match the emsdk feature band -->
<EmscriptenWorkloadFeatureBand>9.0.100$([System.Text.RegularExpressions.Regex]::Match($(EmscriptenWorkloadManifestVersion), `-[A-z]*[\.]*\d*`))</EmscriptenWorkloadFeatureBand>
<EmscriptenWorkloadFeatureBand>9.0.100$([System.Text.RegularExpressions.Regex]::Match($(EmscriptenWorkloadManifestVersion), `-(?!rtm)[A-z]*[\.]*\d*`))</EmscriptenWorkloadFeatureBand>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a comment here about the rtm bit help future devs?

…0918.5

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rtm.24467.13 -> To Version 9.0.0-rtm.24468.5
@jeffschwMSFT
Copy link
Member

who has the next step on unblocking this dependency flow?

@lewing
Copy link
Member

lewing commented Sep 20, 2024

who has the next step on unblocking this dependency flow?

waiting on dotnet/runtime#107997 now, once it lands and runtime can promote builds that will flow here.

@lewing
Copy link
Member

lewing commented Sep 20, 2024

ok now we're waiting on the official build and flow.

@lewing
Copy link
Member

lewing commented Sep 21, 2024

ok now we're waiting on the official build and flow.

first the build timed out then the build promotion failed in the auth step

dotnet-maestro bot and others added 2 commits September 21, 2024 17:35
…0920.3

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rtm.24468.5 -> To Version 9.0.0-rtm.24470.3

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 9.0.0-rc.2.24464.3 -> To Version 9.0.0-rtm.24469.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@lewing
Copy link
Member

lewing commented Sep 21, 2024

I manually kicked the promotion along and triggered the subscription 😩 - Almost 24 hours later we have a build here.

@lewing
Copy link
Member

lewing commented Sep 21, 2024

And now it is failing here because of the broken crossgen

D:\a\_work\1\s\src\Installer\redist-installer\targets\Crossgen.targets(177,5): error MSB6006: "crossgen2" exited with code 57005. [D:\a\_work\1\s\src\Installer\redist-installer\redist-installer.csproj]
##[error]src\Installer\redist-installer\targets\Crossgen.targets(177,5): error MSB6006: (NETCORE_ENGINEERING_TELEMETRY=Build) "crossgen2" exited with code 57005.

@lewing
Copy link
Member

lewing commented Sep 21, 2024

@jeffschwMSFT @steveisok @mangod9 so I believe that means we are now blocked on dotnet/runtime#108088 merging and making it here.

@steveisok
Copy link
Member

@jeffschwMSFT @steveisok @mangod9 so I believe that means we are now blocked on dotnet/runtime#108088 merging and making it here.

That'll make its way here once tactics approves and we merge in runtime.

…0923.2

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rtm.24470.3 -> To Version 9.0.0-rtm.24473.2
@lewing
Copy link
Member

lewing commented Sep 23, 2024

Ok, I triggered the flow with the threadid fix

@lewing lewing enabled auto-merge (squash) September 23, 2024 23:32
@lewing lewing merged commit 253ccea into release/9.0.1xx Sep 23, 2024
34 of 35 checks passed
@lewing lewing deleted the darc-release/9.0.1xx-267cd099-a492-43b3-959e-7a81a38f6ef4 branch September 23, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants