Shutdown toolset compilers #43135
Shutdown toolset compilers #43135
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
AFAICT this won't help with #20183, but won't hurt either. |
| private static readonly string s_toolsetPackageName = "microsoft.net.sdk.compilers.toolset"; | ||
| private static readonly string s_vbcsCompilerExeFileName = "VBCSCompiler.exe"; | ||
| private static readonly string s_shutdownArg = "-shutdown"; | ||
|
|
||
| internal static readonly string VBCSCompilerPath = Path.Combine( |
There was a problem hiding this comment.
Can this be a private static too? The inconsistency between the fields is itching at me.
There was a problem hiding this comment.
It's used in tests currently, I can add a comment.
There was a problem hiding this comment.
No need for comment. Was just curious.
There was a problem hiding this comment.
(note that this PR targets release/9.0.1xx, but I'm unsure that's correct)
There was a problem hiding this comment.
Where did you want to ship this? 9.0.1xx is still open for checkins unless they are breaking changes or high risk.
There was a problem hiding this comment.
Ideally .NET 9 so it's shipped with the other torn sdk changes, I wasn't sure it meets the bar, but it shouldn't be high risk.
|
@rainersigwald for a second review, thanks |
1 similar comment
|
@rainersigwald for a second review, thanks |
Part of dotnet/roslyn#72672.