Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer redirecting VSIX #42861

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Add analyzer redirecting VSIX #42861

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
62154cf
Add analyzer redirecting VSIX
jjonescz Aug 20, 2024
cdb4892
Fix infra
jjonescz Aug 26, 2024
2ed93ed
Merge branch 'main' into analyzer-redirecting
jjonescz Aug 26, 2024
53a5074
Add to UnitTests.proj
jjonescz Aug 26, 2024
5928f32
Implement path redirect
jjonescz Aug 29, 2024
5165f0f
Merge branch 'main' into analyzer-redirecting
jjonescz Aug 29, 2024
9807811
Implement redirector API
jjonescz Aug 30, 2024
4e01a87
Improve code
jjonescz Aug 30, 2024
cdac6cc
Update roslyn
jjonescz Sep 2, 2024
7a31ffb
Simplify slash handling
jjonescz Sep 2, 2024
586ced5
Simplify version matching
jjonescz Sep 2, 2024
c4a206a
Merge branch 'main' into analyzer-redirecting
jjonescz Sep 2, 2024
e65c1c0
Add transport package for VS deployment
jjonescz Sep 4, 2024
61af4e8
Merge branch 'main' into analyzer-redirecting
jjonescz Sep 4, 2024
245b2f1
Consume the API from Workspaces
jjonescz Sep 9, 2024
f5d671e
Update roslyn
jjonescz Sep 10, 2024
92e2284
Merge branch 'main' into analyzer-redirecting
jjonescz Sep 10, 2024
f0b86a4
Add comments
jjonescz Sep 13, 2024
d5a3924
Merge branch 'main' into analyzer-redirecting
jjonescz Jan 13, 2025
5da7cda
Remove Lazy
jjonescz Jan 15, 2025
6a8f110
Extend tests
jjonescz Jan 15, 2025
8680087
Update Roslyn
jjonescz Jan 15, 2025
f73918a
Merge branch 'main' into analyzer-redirecting
jjonescz Jan 15, 2025
74518c1
Extend tests
jjonescz Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,50 @@ namespace Microsoft.Net.Sdk.AnalyzerRedirecting.Tests;

public class SdkAnalyzerAssemblyRedirectorTests(ITestOutputHelper log) : SdkTest(log)
{
[Fact]
public void SameMajorMinorVersion()
[Theory]
[InlineData("9.0.0-preview.5.24306.11", "9.0.0-preview.7.24406.2")]
333fred marked this conversation as resolved.
Show resolved Hide resolved
[InlineData("9.0.100", "9.0.200")]
[InlineData("9.0.100", "9.0.101")]
public void SameMajorMinorVersion(string a, string b)
{
TestDirectory testDir = _testAssetsManager.CreateTestDirectory(identifier: "RuntimeAnalyzers");

var vsDir = Path.Combine(testDir.Path, "vs");
var vsAnalyzerPath = FakeDll(vsDir, @"AspNetCoreAnalyzers\9.0.0-preview.5.24306.11\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var sdkAnalyzerPath = FakeDll(testDir.Path, @"sdk\packs\Microsoft.AspNetCore.App.Ref\9.0.0-preview.7.24406.2\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var vsAnalyzerPath = FakeDll(vsDir, @$"AspNetCoreAnalyzers\{a}\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var sdkAnalyzerPath = FakeDll(testDir.Path, @$"sdk\packs\Microsoft.AspNetCore.App.Ref\{b}\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");

var resolver = new SdkAnalyzerAssemblyRedirector(vsDir);
var redirected = resolver.RedirectPath(sdkAnalyzerPath);
redirected.Should().Be(vsAnalyzerPath);
}

[Fact]
public void DifferentPathSuffix()
{
TestDirectory testDir = _testAssetsManager.CreateTestDirectory(identifier: "RuntimeAnalyzers");

var vsDir = Path.Combine(testDir.Path, "vs");
FakeDll(vsDir, @"AspNetCoreAnalyzers\9.0.0-preview.5.24306.11\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var sdkAnalyzerPath = FakeDll(testDir.Path, @"sdk\packs\Microsoft.AspNetCore.App.Ref\9.0.0-preview.7.24406.2\analyzers\dotnet\vb", "Microsoft.AspNetCore.App.Analyzers");

var resolver = new SdkAnalyzerAssemblyRedirector(vsDir);
var redirected = resolver.RedirectPath(sdkAnalyzerPath);
redirected.Should().BeNull();
}

[Theory]
[InlineData("8.0.100")]
[InlineData("9.1.100")]
public void DifferentMajorMinorVersion(string version)
[InlineData("8.0.100", "9.0.0-preview.7.24406.2")]
[InlineData("9.1.100", "9.0.0-preview.7.24406.2")]
[InlineData("9.0.100", "9.1.100")]
[InlineData("9.0.100", "10.0.100")]
[InlineData("9.9.100", "9.10.100")]
public void DifferentMajorMinorVersion(string a, string b)
{
TestDirectory testDir = _testAssetsManager.CreateTestDirectory(identifier: "RuntimeAnalyzers");

var vsDir = Path.Combine(testDir.Path, "vs");
FakeDll(vsDir, @$"AspNetCoreAnalyzers\{version}\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var sdkAnalyzerPath = FakeDll(testDir.Path, @"sdk\packs\Microsoft.AspNetCore.App.Ref\9.0.0-preview.7.24406.2\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
FakeDll(vsDir, @$"AspNetCoreAnalyzers\{a}\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");
var sdkAnalyzerPath = FakeDll(testDir.Path, @$"sdk\packs\Microsoft.AspNetCore.App.Ref\{b}\analyzers\dotnet\cs", "Microsoft.AspNetCore.App.Analyzers");

var resolver = new SdkAnalyzerAssemblyRedirector(vsDir);
var redirected = resolver.RedirectPath(sdkAnalyzerPath);
Expand Down