fix bug in workload history recorder #42536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Workloads
untriaged
marcpopMSFT
reviewed
Aug 6, 2024
| @@ -54,15 +54,16 @@ public void Run(Action workloadAction) | |||
| private WorkloadHistoryState GetWorkloadState() | |||
| { | |||
| var resolver = _workloadResolverFunc(); | |||
| var currentWorkloadInfo = resolver.GetWorkloadVersion(); | |||
| var currentWorkloadVersion = resolver.GetWorkloadVersion(); | |||
| currentWorkloadVersion = currentWorkloadVersion.Contains("manifest") ? string.Empty : currentWorkloadVersion; | |||
There was a problem hiding this comment.
Is there an api that tells you you're in workload set (or not) mode that you could use instead of doing the string check?
There was a problem hiding this comment.
It sounded like there was consensus behind this, so I implemented it. I want to point out, however, that it made the PR roughly 25x as big...albeit from 'tiny' to 'small'
marcpopMSFT
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it interprets the hashed form of the version as a workload set version