Refactor artifacts size tests #42447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ellahathaway
force-pushed
the
artifact-size-refactor
branch
from
5909a48 to
0462ce7
Compare
ellahathaway
force-pushed
the
artifact-size-refactor
branch
from
0462ce7 to
7379925
Compare
3 tasks
mthalman
reviewed
Jul 30, 2024
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/ArtifactsSizeTests.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/ArtifactsSizeTests.cs
Outdated
Show resolved
Hide resolved
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/ArtifactsSizeTests.cs
Show resolved
Hide resolved
src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/ArtifactsSizeTests.cs
Outdated
Show resolved
Hide resolved
...est/Microsoft.DotNet.SourceBuild.SmokeTests/assets/ArtifactsSizeTests/ArtifactExclusions.txt
Outdated
Show resolved
Hide resolved
| # 'folder/' is equivalent to 'folder/**. It matches 'folder/', 'folder/abc', and 'folder/abc/def/' | ||
|
|
||
| metadata/workloads/x.y.z/userlocal|sdk | ||
| packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/sdk/nonportable.txt|sdk |
There was a problem hiding this comment.
This file strikes me as odd. I wonder why we ship it?
There was a problem hiding this comment.
I'm not sure. Filed dotnet/source-build#4533 in response.
mthalman
approved these changes
Jul 30, 2024
MichaelSimons
approved these changes
Jul 30, 2024
|
@dotnet/source-build-internal - Can I get help merging this? The two pending checks were cancelled due to pool issues.... I'm not sure why they're showing as in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4528 and dotnet/source-build#4475
This PR accomplishes the following items:
Test runs (internal Microsoft links):