Avoid "missing toolset" error in design-time builds #42360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
rainersigwald
approved these changes
Jul 25, 2024
baronfel
approved these changes
Jul 25, 2024
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/sdk/actions/runs/10112336347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172605
Part of #41791.
Summary
A new error trying to detect builds run with a split SDK/compiler inadvertently triggered when projects are opened in some cases, blocking NuGet restore and build in VS scenarios.
Customer Impact
Opening a .NET SDK project in Visual Studio can fail to restore packages and load the project with
NETSDK1216.Regression?
Yes, introduced in 2a0c0f0.
Testing
Manual execution of scenario.
Risk
Low--avoids executing a new target that provides error information about a failed-to-restore state in cases where it shouldn't run. The target never existed before so it definitely didn't run in design-time builds then.