[main] Update dependencies from dotnet/test-templates

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/test-templates

• Subscription: df18da90-7007-4624-9744-08dc65780c30
• Build: 20240808.1
• Date Produced: August 8, 2024 12:18:19 PM UTC
• Commit: 91d725ca4bb6b9d3ad43715cf1c100626be794f1
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.test-templates: from 1.1.0-rc.24407.2 to 1.1.0-rc.24408.1
  • Microsoft.DotNet.Test.ProjectTemplates.9.0: from 1.1.0-rc.24407.2 to 1.1.0-rc.24408.1

[nagilson]

same as #42258

[nagilson]

@dotnet/product-construction
Source-build, please look at this invalid cast.

CSC(0,0): error AD0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer 'Microsoft.NetCore.Analyzers.InteropServices.UseValidPlatformString' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'VolatileNode[Microsoft.CodeAnalysis.IParameterSymbol,System.Boolean][]' to type 'Microsoft.CodeAnalysis.Operations.IInvocationOperation'.'.

[Forgind]

@dotnet/product-construction

[ericstj]

I mentioned in the Teams chat, but also sharing here in case folks can investigate.

There are test failures here that require investigation:

System.InvalidOperationException : Failed to execute /vmr/artifacts/obj/extracted-dotnet-sdk/dotnet test /bl:/vmr/artifacts/scenario-tests/artifacts/SdkTemplateTests_MSTest_VB/test.binlog\nExit code: 1\n/vmr/artifacts/scenario-tests/artifacts/SdkTemplateTests_MSTest_VB/SdkTemplateTests_MSTest_VB.vbproj : error : Could not resolve SDK "MSTest.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
/vmr/artifacts/scenario-tests/artifacts/SdkTemplateTests_MSTest_VB/SdkTemplateTests_MSTest_VB.vbproj : error :   SDK resolver "Microsoft.DotNet.MSBuildWorkloadSdkResolver" returned null.
/vmr/artifacts/scenario-tests/artifacts/SdkTemplateTests_MSTest_VB/SdkTemplateTests_MSTest_VB.vbproj : error :   The NuGetSdkResolver did not resolve this SDK because there was no version specified in the project or global.json.
/vmr/artifacts/scenario-tests/artifacts/SdkTemplateTests_MSTest_VB/SdkTemplateTests_MSTest_VB.vbproj : error MSB4236: The SDK 'MSTest.Sdk' specified could not be found.\n

Stack trace
   at Microsoft.DotNet.ScenarioTests.Common.ExecuteHelper.ValidateExitCode(ValueTuple`3 result, Int32 expectedExitCode) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.Common/ExecuteHelper.cs:line 106
   at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteCmd(String args, String workingDirectory, Action`1 additionalProcessConfigCallback, Int32 expectedExitCode, Int32 millisecondTimeout) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 37
   at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.DotNetSdkHelper.ExecuteTest(String projectDirectory) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkHelper.cs:line 245
   at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTest.Execute(DotNetSdkHelper dotNetHelper, String testRoot, String[] frameworks, String PreMadeSolution) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTest.cs:line 98
   at Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyMSTestTemplate(DotNetLanguage language) in /_/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs:line 84
   at InvokeStub_SdkTemplateTests.VerifyMSTestTemplate(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

[ericstj]

Probably caused by dotnet/test-templates#421 which removed the MSTest.Sdk version from the templates. @Evangelink @MarcoRossignoli can you have a look?

[Evangelink]

Sure I will have a look! It's rather strange because we are using some new templating mechanism that allows to create or edit the global.json file (see https://github.com/dotnet/test-templates/pull/421/files#diff-670120659db7476b808d40102bbc7dfe64f8fa5d2c288a2aba08713a1dea8a06R86-R87). This new feature was developed here #41959

[ericstj]

Sure I will have a look! It's rather strange because we are using some new templating mechanism that allows to create or edit the global.json file (see https://github.com/dotnet/test-templates/pull/421/files#diff-670120659db7476b808d40102bbc7dfe64f8fa5d2c288a2aba08713a1dea8a06R86-R87). This new feature was developed here #41959

Double check that the SDK applying your templates has that feature, if it does then it's possible that feature isn't working as expected if this is the first time you're using it.

I'm not sure if it's significant but it's only failing on Ubuntu, windows tests pass. Could be something about casing / path separators / line endings / etc. I found something suspect here: https://github.com/dotnet/test-templates/pull/421/files#r1698713316

[Evangelink]

I confirm @ericstj analysis. Sadly test-templates repo is not running tests on non-Windows OSes so this was not caught before, I'll try to take some time to work on updating the infra there.

I have created this PR dotnet/test-templates#429 to fix the issue. I don't know if you want to close this PR and wait for next insertion or keep it open.

[ericstj]

We can keep this open. It will auto-update when a new build is available.

[Evangelink]

I have done some local validation of VB.NET and F# too on Linux and the templates are working fine so not sure what's going-on with the source build leg. I have restarted the build just in case this is something flaky.

[Forgind]

@dotnet/source-build-internal, looks like the last failure is the source build leg. Mind taking a look?

[MichaelSimons]

@dotnet/source-build-internal, looks like the last failure is the source build leg. Mind taking a look?

This looks like the same issue as before. @Evangelink, any update on your investigation?

[Evangelink]

Manual tests are working fine for all 3 languages so I would suspect something with the test infra of that particular test but I wasn't able to find how to run this test locally (dotnet test isn't working as files are not copied, build.cmd -test is not running it)

[Evangelink]

While getting some support/feedback on how to debug the source build integration test, I have reverted the usage of global.json in test-templates (see dotnet/test-templates#441), this should unblock this PR.

cc @baronfel