Fix MSBuildVersionMajorMinor assignment #42210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
related to the bug in MSBuild: dotnet/msbuild#10393 |
|
Thanks for digging into this, what a subtle issue! |
baronfel
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2111557/?view=edit
The issue is caused by
ToStringusage. On the first evaluation iteration, this method can't be resolved ,because MSBuild doesn't parse the argument "2" as integer, so runtime can't resolve the right method from System.Version.System.Version lib provides a secure way to parse major/minor version parts.
Testing
Manual, the evidence is provided on the screenshot above.