Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload VM test improvements #42021

Merged

Conversation

dsplaisted
Copy link
Member

Load test workload set versions from a testworkloadsetversions.json file on the VM. This allows the tests to run against different feature bands without changes to the tests themselves.

Also make a fix to only install additional runtimes when deploying stage 2, which fixes an installation / uninstallation test.

@dsplaisted dsplaisted requested review from Forgind and a team July 8, 2024 15:40
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Workloads untriaged Request triage from a team member labels Jul 8, 2024
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good to me, thanks! :)

src/Tests/dotnet-MsiInstallation.Tests/WorkloadSetTests.cs Outdated Show resolved Hide resolved
public WorkloadSetTests(ITestOutputHelper log) : base(log)
{
_testWorkloadSetVersions = new Lazy<Dictionary<string, string>>(() =>
{
var versionsFile = VM.GetRemoteFile(@"c:\SdkTesting\workloadsets\testworkloadsetversions.json");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcpopMSFT marcpopMSFT enabled auto-merge July 9, 2024 20:12
@marcpopMSFT marcpopMSFT merged commit 73e0054 into dotnet:release/8.0.4xx Jul 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants