Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Source-Build SDK Diff Tests Baselines and Exclusions #41929
Update Source-Build SDK Diff Tests Baselines and Exclusions #41929
Changes from 3 commits
929cf1f
9065ad7
b208803
41265a5
5bb1aec
7cfe46e
a08702a
cadd4f8
6d09bd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update the exclusions list to account for this one. It should've been included in the last PR update since it went along with those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The microsoft sdk has the following content in
sdk-manifests/
:The source-build sdk has the following content in
sdk-manifests/
:@MiYanni - Do you know if this is expected? Is the microsoft sdk supposed to have the preview 1 manifests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I don't actually know the composition of the SDK. @marcpopMSFT Does that look like it makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from here and is used in BundledManifests.targets.
This should definitely get updated to the latest, i.e. https://www.nuget.org/packages/Microsoft.NET.Sdk.Maui.Manifest-9.0.100-preview.5/9.0.0-preview.5.24307.10#readme-body-tab
The last time this was done was in dotnet/installer#18693.
@jonathanpeppers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These always lag behind 1 release, as we want publicly listed packages. There is kind of a circular dependency here, .NET SDK -> MAUI -> .NET SDK. So, when .NET 9 GAs, we'll probably have .NET 9 RC 2 manifests in here.
We could update it now, though: it's been a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we currently lagging 5 preview releases behind? I assume there is no automated process in place that makes sure those get updated? And what's the customer impact here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of any customer impact. I suppose you wouldn't get the latest workloads if you used the
--skip-manifest-update
switch.To automate this, we might be able to use the same Maestro subscription that this repo will be using:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellahathaway if the source-build SDK doesn't contain maui workloads, then the missing
9.0.100-preview.1/
folder is expected and should be ignored. Note as discussed above, the folder name will change whenever the workload manifests for maui are updated.@jonathanpeppers can you please file an issue in dotnet/sdk? We should probably also get the manifest updated from P1 to P5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I think the best course of action here is to add this diff to the baseline. I'll update this PR accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just opened a PR with the builds that shipped yesterday: