[Issue #37237 #19650] Dotnet Cli Feature: dotnet tool update --all Updating all tools with one command

src/Cli/dotnet/commands/dotnet-tool/common/ToolAppliedOption.cs

@@ -2,7 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.CommandLine;
+using Microsoft.DotNet.Cli;
 using Microsoft.DotNet.Cli.Utils;
+using UpdateToolsLocalizableStrings = Microsoft.DotNet.Tools.Tool.Update.LocalizableStrings;
 
 namespace Microsoft.DotNet.Tools.Tool.Common
 {
@@ -12,6 +14,13 @@ internal class ToolAppliedOption
 
         public static CliOption<bool> LocalOption = new("--local");
 
+        public static CliOption<bool> UpdateAllOption = new("--all")
+        {
+            Description = UpdateToolsLocalizableStrings.UpdateAllOptionDescription
+        };
+
+        public static readonly CliOption<string> VersionOption = ToolInstallCommandParser.VersionOption;
+
         public static CliOption<string> ToolPathOption = new("--tool-path")
         {
             HelpName = Install.LocalizableStrings.ToolPathOptionName
@@ -45,7 +54,30 @@ internal static void EnsureNoConflictGlobalLocalToolPathOption(
 
             if (options.Count > 1)
             {
+                throw new GracefulException(
+                    string.Format(
+                        message,
+                        string.Join(" ", options)));
+            }
+        }
+
+        internal static void EnsureNoConflictUpdateAllVersionOption(
+            ParseResult parseResult,
+            string message)
+        {
+            List<string> options = new List<string>();
+            if (parseResult.GetResult(UpdateAllOption) is not null)
+            {
+                options.Add(UpdateAllOption.Name);
+            }
 
+            if (parseResult.GetResult(VersionOption) is not null)
+            {
+                options.Add(VersionOption.Name);
+            }
+
+            if (options.Count > 1)
+            {
                 throw new GracefulException(
                     string.Format(
                         message,

src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallCommandParser.cs

@@ -86,6 +86,7 @@ public static CliCommand GetCommand()
         private static CliCommand ConstructCommand()
         {
             CliCommand command = new("install", LocalizableStrings.CommandDescription);
+            command.Arguments.Add(PackageIdArgument);
 
             AddCommandOptions(command);
 
@@ -100,8 +101,7 @@ private static CliCommand ConstructCommand()
         }
 
         public static CliCommand AddCommandOptions(CliCommand command)
-        {
-            command.Arguments.Add(PackageIdArgument);
+        {   
             command.Options.Add(GlobalOption.WithHelpDescription(command, LocalizableStrings.GlobalOptionDescription));
             command.Options.Add(LocalOption.WithHelpDescription(command, LocalizableStrings.LocalOptionDescription));
             command.Options.Add(ToolPathOption.WithHelpDescription(command, LocalizableStrings.ToolPathOptionDescription));
@@ -118,6 +118,6 @@ public static CliCommand AddCommandOptions(CliCommand command)
             command.Options.Add(VerbosityOption);
 
             return command;
-        } 
+        }
     }
 }

src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallGlobalOrToolPathCommand.cs

@@ -16,7 +16,9 @@
 using NuGet.Common;
 using NuGet.Frameworks;
 using NuGet.Versioning;
+using Microsoft.DotNet.Tools.Tool.List;
 using static System.Formats.Asn1.AsnWriter;
+using System.CommandLine.Parsing;
 
 namespace Microsoft.DotNet.Tools.Tool.Install
 {
@@ -34,8 +36,9 @@ internal class ToolInstallGlobalOrToolPathCommand : CommandBase
         private CreateShellShimRepository _createShellShimRepository;
         private readonly CreateToolPackageStoresAndDownloaderAndUninstaller _createToolPackageStoreDownloaderUninstaller;
         private readonly ShellShimTemplateFinder _shellShimTemplateFinder;
+        private readonly IToolPackageStoreQuery _store;
 
-        private readonly PackageId _packageId;
+        private readonly PackageId? _packageId;
         private readonly string _packageVersion;
         private readonly string _configFilePath;
         private readonly string _framework;
@@ -47,18 +50,22 @@ internal class ToolInstallGlobalOrToolPathCommand : CommandBase
         private IEnumerable<string> _forwardRestoreArguments;
         private readonly bool _allowRollForward;
         private readonly bool _allowPackageDowngrade;
+        private readonly bool _updateAll;
 
 
         public ToolInstallGlobalOrToolPathCommand(
             ParseResult parseResult,
+            PackageId? packageId = null,
             CreateToolPackageStoresAndDownloaderAndUninstaller createToolPackageStoreDownloaderUninstaller = null,
             CreateShellShimRepository createShellShimRepository = null,
             IEnvironmentPathInstruction environmentPathInstruction = null,
             IReporter reporter = null,
-            INuGetPackageDownloader nugetPackageDownloader = null)
+            INuGetPackageDownloader nugetPackageDownloader = null,
+            IToolPackageStoreQuery store = null)
             : base(parseResult)
         {
-            _packageId = new PackageId(parseResult.GetValue(ToolInstallCommandParser.PackageIdArgument));
+            var packageIdArgument = parseResult.GetValue(ToolInstallCommandParser.PackageIdArgument);
+            _packageId = packageId ?? (packageIdArgument is not null ? new PackageId(packageIdArgument) : null);
             _packageVersion = parseResult.GetValue(ToolInstallCommandParser.VersionOption);
             _configFilePath = parseResult.GetValue(ToolInstallCommandParser.ConfigOption);
             _framework = parseResult.GetValue(ToolInstallCommandParser.FrameworkOption);
@@ -83,12 +90,14 @@ public ToolInstallGlobalOrToolPathCommand(
                 Interactive: parseResult.GetValue(ToolCommandRestorePassThroughOptions.InteractiveRestoreOption));
             nugetPackageDownloader ??= new NuGetPackageDownloader(tempDir, verboseLogger: new NullLogger(), restoreActionConfig: restoreAction, verbosityOptions: _verbosity);
             _shellShimTemplateFinder = new ShellShimTemplateFinder(nugetPackageDownloader, tempDir, packageSourceLocation);
+            _store = store;
 
             _allowRollForward = parseResult.GetValue(ToolInstallCommandParser.RollForwardOption);
 
             _allowPackageDowngrade = parseResult.GetValue(ToolInstallCommandParser.AllowPackageDowngradeOption);
             _createToolPackageStoreDownloaderUninstaller = createToolPackageStoreDownloaderUninstaller ??
                                                   ToolPackageFactory.CreateToolPackageStoresAndDownloaderAndUninstaller;
+            _updateAll = parseResult.GetValue(ToolUpdateCommandParser.UpdateAllOption);
 
             _reporter = (reporter ?? Reporter.Output);
             _errorReporter = (reporter ?? Reporter.Error);
@@ -106,6 +115,27 @@ public static T GetValueOrDefault<T>(CliOption<T> option, T defaultOption, Parse
         }
 
         public override int Execute()
+        {
+            if (_updateAll)
+            {
+                var toolListCommand = new ToolListGlobalOrToolPathCommand(
+                    _parseResult
+                    , toolPath => { return _store; }
+                    );
+                var toolIds = toolListCommand.GetPackages(null, null);
+                foreach (var toolId in toolIds)
+                {
+                    ExecuteInstallCommand(new PackageId(toolId.Id.ToString()));
+                }
+                return 0;
+            }
+            else
+            {
+                return ExecuteInstallCommand((PackageId)_packageId);
+            }
+        }
+
+        private int ExecuteInstallCommand(PackageId packageId)
         {
             ValidateArguments();
 
@@ -125,7 +155,7 @@ public override int Execute()
             var appHostSourceDirectory = ShellShimTemplateFinder.GetDefaultAppHostSourceDirectory();
             IShellShimRepository shellShimRepository = _createShellShimRepository(appHostSourceDirectory, toolPath);
 
-            IToolPackage oldPackageNullable = GetOldPackage(toolPackageStoreQuery);
+            IToolPackage oldPackageNullable = GetOldPackage(toolPackageStoreQuery, packageId);
 
             using (var scope = new TransactionScope(
                 TransactionScopeOption.Required,
@@ -141,14 +171,14 @@ public override int Execute()
                         }
 
                         toolPackageUninstaller.Uninstall(oldPackageNullable.PackageDirectory);
-                    });
+                    }, packageId);
                 }
 
                 RunWithHandlingInstallError(() =>
                 {
                     IToolPackage newInstalledPackage = toolPackageDownloader.InstallPackage(
                     new PackageLocation(nugetConfig: GetConfigFile(), additionalFeeds: _source),
-                        packageId: _packageId,
+                        packageId: packageId,
                         versionRange: versionRange,
                         targetFramework: _framework,
                         verbosity: _verbosity,
@@ -188,11 +218,11 @@ public override int Execute()
                     }
 
                     PrintSuccessMessage(oldPackageNullable, newInstalledPackage);
-                });
+                }, packageId);
 
                 scope.Complete();
-                
-            } 
+
+            }
             return 0;
         }
 
@@ -222,7 +252,7 @@ private void ValidateArguments()
             }
         }
 
-        private void RunWithHandlingInstallError(Action installAction)
+        private void RunWithHandlingInstallError(Action installAction, PackageId packageId)
         {
             try
             {
@@ -233,10 +263,10 @@ private void RunWithHandlingInstallError(Action installAction)
             {
                 var message = new List<string>
                 {
-                    string.Format(Update.LocalizableStrings.UpdateToolFailed, _packageId)
+                    string.Format(Update.LocalizableStrings.UpdateToolFailed, packageId)
                 };
                 message.AddRange(
-                    InstallToolCommandLowLevelErrorConverter.GetUserFacingMessages(ex, _packageId));
+                    InstallToolCommandLowLevelErrorConverter.GetUserFacingMessages(ex, packageId));
 
 
                 throw new GracefulException(
@@ -246,7 +276,7 @@ private void RunWithHandlingInstallError(Action installAction)
             }
         }
 
-        private void RunWithHandlingUninstallError(Action uninstallAction)
+        private void RunWithHandlingUninstallError(Action uninstallAction, PackageId packageId)
         {
             try
             {
@@ -257,10 +287,10 @@ private void RunWithHandlingUninstallError(Action uninstallAction)
             {
                 var message = new List<string>
                 {
-                    string.Format(Update.LocalizableStrings.UpdateToolFailed, _packageId)
+                    string.Format(Update.LocalizableStrings.UpdateToolFailed, packageId)
                 };
                 message.AddRange(
-                    ToolUninstallCommandLowLevelErrorConverter.GetUserFacingMessages(ex, _packageId));
+                    ToolUninstallCommandLowLevelErrorConverter.GetUserFacingMessages(ex, packageId));
 
                 throw new GracefulException(
                     messages: message,
@@ -280,12 +310,12 @@ private void RunWithHandlingUninstallError(Action uninstallAction)
             return configFile;
         }
 
-        private IToolPackage GetOldPackage(IToolPackageStoreQuery toolPackageStoreQuery)
+        private IToolPackage GetOldPackage(IToolPackageStoreQuery toolPackageStoreQuery, PackageId packageId)
         {
             IToolPackage oldPackageNullable;
             try
             {
-                oldPackageNullable = toolPackageStoreQuery.EnumeratePackageVersions(_packageId).SingleOrDefault();
+                oldPackageNullable = toolPackageStoreQuery.EnumeratePackageVersions(packageId).SingleOrDefault();
             }
             catch (InvalidOperationException)
             {
@@ -294,7 +324,7 @@ private IToolPackage GetOldPackage(IToolPackageStoreQuery toolPackageStoreQuery)
                     {
                         string.Format(
                             Update.LocalizableStrings.ToolHasMultipleVersionsInstalled,
-                            _packageId),
+                            packageId),
                     },
                     isUserError: false);
             }