Include CodeStyle targets files even when not enforcing code style in build

[mavasani]

Please see the PR description in dotnet/roslyn#72238 (comment), which gives a background on this fix. This change along with that Roslyn PR is needed for fixing the regression in dotnet/roslyn#72094

[arunchndr]

@marcpopMSFT this one blocks another change we might need to present to servicing - dotnet/roslyn#72238. Could we get an approval from your side and merge?

[baronfel]

@dsplaisted / @joeloff any problems with merging this one?

[joeloff]

After reading the issue/comments that were linked, this seems to be something we need. Is this only applicable to newer versions or will these need to be ported to older releases of the SDK as part of servicing?

[mavasani]

After reading the issue/comments that were linked, this seems to be something we need. Is this only applicable to newer versions or will these need to be ported to older releases of the SDK as part of servicing?

Basically any backport of the Roslyn change will be a no-op in VS unless the underlying SDK installed has this change. So, if we are backporting the Roslyn change to VS 17.10, we want to at least backport this SDK change into whichever .NET SDK version is installed as part of 17.10

[cremor]

So, if we are backporting the Roslyn change to VS 17.10, we want to at least backport this SDK change into whichever .NET SDK version is installed as part of 17.10

I'd have hoped that this is released as a VS 17.9.x bugfix?

[mavasani]

So, if we are backporting the Roslyn change to VS 17.10, we want to at least backport this SDK change into whichever .NET SDK version is installed as part of 17.10

I'd have hoped that this is released as a VS 17.9.x bugfix?

Tagging @arkalyanms. I believe this will depend on how many users are hitting this, but I am fine if we feel this should be backported to 17.9. dotnet/roslyn#52991 (comment) has suggestions on how to clean up your editorconfig to avoid hitting this case

[mavasani]

Can someone please help me with the unrelated build failure on this PR?

[baronfel]

This test has been failing consistently across a number of branches - I believe we have a team member trying to root cause it currently.

[mavasani]

This test has been failing consistently across a number of branches - I believe we have a team member trying to root cause it currently.

@baronfel Can this PR be merged overriding the failing test leg?

[dsplaisted]

@baronfel Can this PR be merged overriding the failing test leg?

I am investigating the failing test, but if we can consider disabling the test if we need to get this PR merged quickly. That would be preferrable to having the test consistently failing.

[mavasani]

@baronfel Can this PR be merged overriding the failing test leg?

I am investigating the failing test, but if we can consider disabling the test if we need to get this PR merged quickly. That would be preferrable to having the test consistently failing.

I think that might help as we are considering backporting this fix. I'll let @arkalyanms make a call a here.

[dsplaisted]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cremor]

Tagging @arkalyanms. I believe this will depend on how many users are hitting this, but I am fine if we feel this should be backported to 17.9

@arkalyanms Could you please comment on if this (and dotnet/roslyn#72238) will be backported to 17.9?