-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0.3xx] Update dependencies from nuget/nuget.client #38037
[release/8.0.3xx] Update dependencies from nuget/nuget.client #38037
Conversation
…6.10.0.5 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.5
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…6.10.0.5 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.5
@dotnet/nuget-team did you enable a new enforcement for CPM? I don't want to use package source mapping for the tests so is there a property to disable this check only in the tests? |
CPM is now enabled by default if <Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
</PropertyGroup>
</Project> You can also run functional tests from directories outside of the repo if possible so that those tests don't import the root Directory.Build.props, Directory.Build.targets, Directory.Packages.props, etc. |
CPM was already enabled for that test project and I can't disable it without unwinding a bunch of package references. That particular project appears to build and test at the same time from what I can tell so that means the tests themselves pick up the D.B.props. I can see if I can figure out how to make that change for the test. However, is this a new change in 17.10? If so, that's going to be potentially painful for customers and would violate the principal of no new warnings in minor releases. CC @baronfel |
Yeah this is a pretty big behavioral change - ideally there would be some kind of gradual on-ramp. How many folks do you think are in the triggering scenario today? Is it possible to detect and warn for a release (or until .NET 9) and give a chance for fixing in a non-breaking way? |
There were no warnings added, just that if a Directory.Packages.props was imported then CPM is enabled without having to additionally set That said, I'm just guessing as to the problem based on the warning message pasted above. This is the only recent change that came to mind that might explain what's going on: NuGet/NuGet.Client#5572 If this test was working before and now it isn't, I'd imagine just adding |
Digging into this more, the test project builds in this folder and picks up a directory.packages.props from the root folder: We build the test project into a root\artifacts folder and run the tests from there. I'm not sure the impact of rerouting the tests to a completely different folder (as I believe the build machines don't let me use the full drive). This seems like it would be a fairly common situation as often times tests get run from their build output folder and usually that folder would be under the root node. I'm surprised the tests aren't picking up the root D.B.props which suppresses this warning. They must be finding one somewhere further up the chain that doesn't chain in the root one. I kind of don't like this warning in general as why wouldn't I want to use CPM without package source mapping? I would expect even someone who wants both would enable CPM first as a stepping stone to PSM. Either way, I expect this to potentially cause a lot of customer noise... |
I'm not very familiar with this repo, so I'll need help figuring out how to fix this. I see places where its disabling the import of
As far as I know, the only time you'll never hit something like this is if your repository runs tests that involve evaluating MSBuild projects on-the-fly from the repo itself and are using CPM but you don't explicitly disable CPM. I don't think that's very common from my experience. |
…6.10.0.7 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.7
…6.10.0.8 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.8
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…6.10.0.8 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.8
…6.10.0.9 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.9
…6.10.0.9 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.9
@dotnet/domestic-cat I'm not entirely sure why this nuget update is failing an alias test only on Ubuntu: Unclear to me why the nuget update would even affect that. Thoughts? |
…6.10.0.9 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.9
…6.10.0.12 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.9.0-rc.74 -> To Version 6.10.0-preview.1.12
This pull request updates the following dependencies
From https://github.com/nuget/nuget.client