Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the format of tool exceptions and NuGet API exceptions to be graceful #36641

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Change the format of tool exceptions and NuGet API exceptions to be graceful #36641

merged 4 commits into from
Nov 8, 2023

Conversation

JL03-Yue
Copy link
Member

@JL03-Yue JL03-Yue commented Nov 3, 2023

#36557

Change the format of tool exceptions and NuGet API exceptions to be graceful without default stack dump

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 3, 2023
baronfel
baronfel reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of the different ranges looks good! I think we need:

  • some screenshots of the different error cases
  • tests in-repo for the 'not found' cases and such so we don't regress

@JL03-Yue JL03-Yue merged commit f484f4c into dotnet:release/8.0.2xx Nov 8, 2023
16 checks passed
@JL03-Yue JL03-Yue mentioned this pull request Nov 9, 2023
Closed
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Nov 17, 2023
Closed
@JL03-Yue JL03-Yue mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JL03-Yue @baronfel